Closed
Bug 1359508
Opened 7 years ago
Closed 7 years ago
stylo: Allow llvm 5.0 for stylo.
Categories
(Firefox Build System :: General, enhancement, P2)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
My patch to fix libclang just landed, so there's no reason LLVM 5.0 couldn't be used for stylo now. https://github.com/llvm-mirror/clang/commit/4eaf83fa609ff96d365a7e1059a61aac350717e7
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8861530 [details] Bug 1359508: Allow LLVM 5 for stylo. https://reviewboard.mozilla.org/r/133502/#review136356 I guess we can assume that anyone brave enough to be running LLVM 5.0 at this point is probably running something close to trunk, which contains your bindgen-related fixes?
Attachment #8861530 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 3•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8861530 [details] Bug 1359508: Allow LLVM 5 for stylo. https://reviewboard.mozilla.org/r/133502/#review136356 I think I'm the only one building stylo with trunk right now, and it's not yet released, so I assume people running with trunk know that stuff may break. We can wait a bit if you think it's better, but this has annoyed me a bit, so I'd appreciate removing this patch from my local queue :P
Comment 4•7 years ago
|
||
(In reply to Emilio Cobos Álvarez [:emilio] from comment #3) > We can wait a bit if you think it's better, but this has annoyed me a bit, > so I'd appreciate removing this patch from my local queue :P Landing this now would be fine.
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/01ba782ad7ba Allow LLVM 5 for stylo. r=froydnj
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/01ba782ad7ba
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Blocks: stylo-nightly-build
Priority: -- → P2
Comment 7•7 years ago
|
||
Are we going to wind up on a constant treadmill with bindgen trying to keep up with LLVM upstream? That's pretty unfortunate.
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•