1359508 - stylo: Allow llvm 5.0 for stylo.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P2)

Description

[Emilio Cobos Álvarez [:emilio]]

My patch to fix libclang just landed, so there's no reason LLVM 5.0 couldn't be used for stylo now.

https://github.com/llvm-mirror/clang/commit/4eaf83fa609ff96d365a7e1059a61aac350717e7

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1359508: Allow LLVM 5 for stylo.

Review commit: https://reviewboard.mozilla.org/r/133502/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133502/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8861530 [details]
Bug 1359508: Allow LLVM 5 for stylo.

https://reviewboard.mozilla.org/r/133502/#review136356

I guess we can assume that anyone brave enough to be running LLVM 5.0 at this point is probably running something close to trunk, which contains your bindgen-related fixes?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8861530 [details]
Bug 1359508: Allow LLVM 5 for stylo.

https://reviewboard.mozilla.org/r/133502/#review136356

I think I'm the only one building stylo with trunk right now, and it's not yet released, so I assume people running with trunk know that stuff may break.

We can wait a bit if you think it's better, but this has annoyed me a bit, so I'd appreciate removing this patch from my local queue :P

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #3)
> We can wait a bit if you think it's better, but this has annoyed me a bit,
> so I'd appreciate removing this patch from my local queue :P

Landing this now would be fine.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01ba782ad7ba
Allow LLVM 5 for stylo. r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01ba782ad7ba

Comment 7

[(not currently active) Ted Mielczarek]

Are we going to wind up on a constant treadmill with bindgen trying to keep up with LLVM upstream? That's pretty unfortunate.