1359545 - Update tests to pass triggeringPrincipal to loadURI

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1359545_update_tests_to_pass_triggering_to_loaduri.patch

There is a bunch more work waiting for us/me. Let's get the low hanging fruit out of the way before we can flip the assertion within Bug 1333030.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b176e29b4b8bc04efb9fe89f733328d173f373e

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8861590 [details] [diff] [review]
bug_1359545_update_tests_to_pass_triggering_to_loaduri.patch

The browser/ tests should get review from someone familiar with them.  In particular, for browser_async_remove_tab.js it's not clear to me at all that the changes are right: the import() is in the chrome process but afaict the string is eval'ed in the content process.

r=me on the DOM and toolkit tests.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8861590 [details] [diff] [review]
bug_1359545_update_tests_to_pass_triggering_to_loaduri.patch

Gijs, can you take a look at the browser/ test changes?

Comment 4

[:Gijs (out for now; he/him)]

Comment on attachment 8861590 [details] [diff] [review]
bug_1359545_update_tests_to_pass_triggering_to_loaduri.patch

Review of attachment 8861590 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/test/browser_async_remove_tab.js
@@ +1,3 @@
>  "use strict";
>  
> +Cu.import("resource://gre/modules/Services.jsm");

You shouldn't need to do this. Here or in any other browser_ tests.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1359545_update_tests_to_pass_triggering_to_loaduri.patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9210201f671
Update tests to pass triggeringPrincipal to loadURI. r=bz, r=gijs

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9210201f671