1359597 - Set up new console with devtools-launchpad

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

Splitting this work out from the xhtml conversion in Bug 1326937, since we can get the better local dev set up ahead of time (similar to the netmonitor implementation)

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1359597 - Set up new console with devtools-launchpad;

Review commit: https://reviewboard.mozilla.org/r/133582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133582/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8861615 [details]
Bug 1359597 - Set up new console with devtools-launchpad;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133582/diff/1-2/

Comment 3

[Brian Grinstead [:bgrins]]

This is a first pass at integrating the console with launchpad. I'm hoping to get the launchpad environment set up early so that other console-html work can use it.  Instructions for testing:

* `cd devtools/client/webconsole`
* `yarn install && npm start`
* Open http://localhost:8000/ and follow launchpad instructions

My current plan is to iterate on new-webconsole.js and new-webconsole.css when actually porting the panel to run in xhtml (Bug 1326937).  This is instead of continuing down the current road of sharing the same js/css and switching when using the new frontend - by starting with new files we have a simpler and easier bundle here. 

A couple of known issues:
* No object inspection (until we integrate object inspector)
* No input field (need to use the target page or the injected 'window.eval' function until we have UI

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8861615 [details]
Bug 1359597 - Set up new console with devtools-launchpad;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133582/diff/2-3/

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8861615 [details]
Bug 1359597 - Set up new console with devtools-launchpad;

https://reviewboard.mozilla.org/r/133582/#review136810

This is great!

See my inline comments

Also, I am not seeing icons for toolbar actions (clear, filter) when running the page in Chrome browser

R+ assuming my comments are resolved.

Thanks for working on this!
Honza

::: devtools/client/webconsole/local-dev/index.js:17
(Diff revision 3)
> +const { Services: { appinfo, pref } } = require("devtools-modules");
> +const { bootstrap } = require("devtools-launchpad");
> +
> +EventEmitter.decorate(window);
> +
> +require("../../themes/new-webconsole.css");

Can we also include:
require("../../shared/components/reps/reps.css");

Otherwise styles from bug 1307940 are missing. These are specifying size (16x16) for the inspector icon svg (.open-inspector svg) and if missing I am seeing  giant inspector icon takin most of the space.

::: devtools/client/webconsole/webpack.config.js:122
(Diff revision 3)
> +
> +let config = toolboxConfig(webpackConfig, getConfig());
> +
> +// Remove loaders from devtools-launchpad's webpack.config.js
> +// * For svg-inline loader:
> +//   Netmonitor uses file loader to bundle image assets instead of svg-inline loader

The comment should be updated I guess (no Netmonitor but Webconsole)

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> Comment on attachment 8861615 [details]
> Bug 1359597 - Set up new console with devtools-launchpad;
> 
> https://reviewboard.mozilla.org/r/133582/#review136810
> 
> This is great!
> 
> See my inline comments
> 
> Also, I am not seeing icons for toolbar actions (clear, filter) when running
> the page in Chrome browser

Yeah I noticed that too - plan to address it later on.

> R+ assuming my comments are resolved.

Done, thanks

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8861615 [details]
Bug 1359597 - Set up new console with devtools-launchpad;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133582/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd8f6defbd94
Set up new console with devtools-launchpad;r=Honza

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd8f6defbd94