1359662 - Screen-sharing track.getSettings() returns crazy high values for width and height

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

This is not a regression, rather an unintentional surfacing of an internal hack where width and height are overloaded with internal values [1] that should not have been exposed through getSettings().

[1] https://dxr.mozilla.org/mozilla-central/rev/f229b7e5d91eb70d23d3e31db7caff9d69a2ef04/dom/media/webrtc/MediaEngineRemoteVideoSource.cpp#453-460

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1359662 - Make track.getSettings() output nominal values for width and height instead of crazy high ones.

Review commit: https://reviewboard.mozilla.org/r/133706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133706/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STR:
 1. Open https://jsfiddle.net/jib1/77nqay6w/
 2. Pick Screen to share: "Entire screen", and share screen.
 3. Click the button named "160".

Expected result: Applied 160 x 120 got ~160 x ~120

Actual result: Applied 160 x 120 got 10551295 x 7929855

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

This is a wallpaper patch basically, potentially for uplift if we need it. I've filed bug 1359668 as a follow-up since a proper solution will involve a bit more work.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Is this still relevant given bug 1359668 is fixed?

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Yes, there's a window before the first frame arrives when we return the nominal values, and those are still wrong.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8861722 [details]
Bug 1359662 - Make track.getSettings() output nominal values for width and height instead of crazy high ones.

https://reviewboard.mozilla.org/r/133706/#review136856

Found I had this sitting "Pending" with an r+ ....for a Long Time.  Sorry

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8861722 [details]
Bug 1359662 - Make track.getSettings() output nominal values for width and height instead of crazy high ones.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133706/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15fc82881432
Make track.getSettings() output nominal values for width and height instead of crazy high ones. r=jesup

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/15fc82881432