1359669 - stylo: CSS animation of border-width is wrong

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Brian Birtles (:birtles)]

Attachment: Test case using CSS animations

In the attached test case, the animation looks odd in Stylo and different to Gecko. Specifically, only the right side of the box seems to animate.

Oddly, a very similar test case that uses transitions[1] animates as expected.

[1] http://smfr.org/css/complex-rounded-corners.html

Comment 1

[Hiroyuki Ikezoe (:hiro)]

We return correct keyframes for the test case but return wrong ComputedKeyframeValues.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=150b68e09bb6767688c86cb2fbe812ac2c078042

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1359669 - Set multiple properties in a keyframe correctly.

Review commit: https://reviewboard.mozilla.org/r/135350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135350/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1359669 - Update mochitest and reftest expectations for multiple properties in a keyframe.

Review commit: https://reviewboard.mozilla.org/r/135352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135352/

Comment 5

[Brian Birtles (:birtles)]

Comment on attachment 8863587 [details]
Bug 1359669 - Set multiple properties in a keyframe correctly.

https://reviewboard.mozilla.org/r/135350/#review138332

Comment 6

[Brian Birtles (:birtles)]

Comment on attachment 8863588 [details]
Bug 1359669 - Update mochitest and reftest expectations for multiple properties in a keyframe.

https://reviewboard.mozilla.org/r/135352/#review138334

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8863588 [details]
Bug 1359669 - Update mochitest and reftest expectations for multiple properties in a keyframe.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135352/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8cf70e02740
Update mochitest and reftest expectations for multiple properties in a keyframe. r=birtles

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f8cf70e02740