Closed
Bug 1359731
Opened 7 years ago
Closed 7 years ago
CryptoStore.importPrivateKey enhancements
Categories
(JSS Graveyard :: Library, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ftweedal, Assigned: glenbeasley)
Details
Attachments
(3 files)
|
4.67 KB,
patch
|
cfu
:
review+
|
Details | Diff | Splinter Review |
|
4.53 KB,
patch
|
cfu
:
review+
|
Details | Diff | Splinter Review |
|
1.51 KB,
patch
|
cfu
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20170310133403 Expected results: Enhance CryptoStore.importPrivateKey to support temporary import, and returning the private key to the caller. Also remove some validation of the unused keyType argument.
|
Reporter | |
Comment 1•7 years ago
|
||
Attachment #8861816 -
Flags: review?(cfu)
|
|
Reporter | |
Comment 2•7 years ago
|
||
Attachment #8861817 -
Flags: review?(cfu)
|
|
Reporter | |
Comment 3•7 years ago
|
||
Attachment #8861818 -
Flags: review?(cfu)
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8861816 [details] [diff] [review] jss-ftweedal-0003-CryptoStore.importPrivateKey-support-temporary-keys.patch Review of attachment 8861816 [details] [diff] [review]: ----------------------------------------------------------------- looks good. I'm surprised that we never had temporary import before.
Attachment #8861816 -
Flags: review?(cfu) → review+
|
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8861817 [details] [diff] [review] jss-ftweedal-0004-CryptoStore.importPrivateKey-return-PrivateKey-objec.patch Review of attachment 8861817 [details] [diff] [review]: ----------------------------------------------------------------- makes sense.
Attachment #8861817 -
Flags: review?(cfu) → review+
|
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8861818 [details] [diff] [review] jss-ftweedal-0005-CryptoStore.importPrivateKey-ignore-keyType-argument.patch Review of attachment 8861818 [details] [diff] [review]: ----------------------------------------------------------------- looks fine.
Attachment #8861818 -
Flags: review?(cfu) → review+
|
||
Comment 7•7 years ago
|
||
Pushed: https://hg.mozilla.org/projects/jss/rev/ead2ea094c98ddc708169c3de411ca8d8883cab8
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•