1359824 - Multiprocess compatible error displayed for Themes and Plugins in Add-ons Manager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: mpcerror.zip

[Affected versions]:
Firefox 55.0a1 (2017-04-26)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 14.04 64-bit

[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Navigate to about:addons -> Appearance/Plugins


[Expected Results]:
There is no error displayed for themes and plugins in Add-ons Manager.


[Actual Results]:
- “[Name] has been disabled since it is not multiprocess compatible” error appears for all themes and plugins installed and the “Enable”/”Disable” buttons are still displayed.
- See attached screenshots.

Comment 2

[Vasilica Tamas, QA [:vtamas]]

I’m not sure this is a dupe of Bug 1359476 because themes and plugins are not actually disabled and they can still be installed. The only issue here is that mpc error message is displayed. While the dictionaries and lang packs are entirely disabled and their installation is blocked.

Comment 3

[Andrew Swan [:aswan]]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #2)
> I’m not sure this is a dupe of Bug 1359476 because themes and plugins are
> not actually disabled and they can still be installed. The only issue here
> is that mpc error message is displayed. While the dictionaries and lang
> packs are entirely disabled and their installation is blocked.

whoops, you're right, thanks.

Comment 4

[Andrew Swan [:aswan]]

Attachment: Bug 1359824 Only display error for disabled addons

Also fixed some existing errors in the non-mpc browser test found
while working on this...

Review commit: https://reviewboard.mozilla.org/r/134036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134036/

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8862072 [details]
Bug 1359824 Only display error for disabled addons

https://reviewboard.mozilla.org/r/134036/#review136988

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/175439e20aa5
Only display error for disabled addons r=mossop

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/175439e20aa5

Comment 8

[Vasilica Tamas, QA [:vtamas]]

Confirm that multiprocess error is no longer displayed for themes, plugins, dictionaries and lang packs on Firefox 55.0a1 (2017-04-28) and test builds from https://bugzilla.mozilla.org/show_bug.cgi?id=1352204#c27 under Windows 10 64-bit, Ubuntu 14.04 64-bit and Mac OS X 10.12.1. See screenshot: https://www.screencast.com/t/NV1Ftmf7cC