135984 - mailto: URL with %20 in it screws up "to" field

Status: RESOLVED FIXED

(MailNews Core :: Networking, defect)

Description

[John Keiser (jkeiser)]

STEPS TO REPRODUCE:
1. Type "mailto:[e-mail]?to=[e-mail]&body=a%20b" into the URL bar or click the
testcase URL.

EXPECTED RESULTS:
Two "To:" lines showing [e-mail] and [e-mail]

ACTUAL RESULTS:
One "To:" line showing: ""a\"@[e-mail]

Note that mailto:[e-mail]?body=a%20b and
mailto:[e-mail]?cc=[e-mail]&cc=[e-mail]&body=a%20b both work, so it appears to be
specific to "To:".

Comment 1

[Antonio.Xu]

hi mscott could you assign this bug to me? 

Comment 2

[Antonio.Xu]

please assign this bug to me, i'm sure i can fix it.

Comment 3

[Antonio.Xu]

Attachment: this is a new patch for this bug,please rv my patch

Hi Mscott,this is my fix for this bug,i know you are so busy,could you rv my
patch?Thank you.

Comment 4

[Antonio.Xu]

Somebody can rv my patch.

Comment 5

[Antonio.Xu]

my fix is only swich some lines,it is because when 
ParseMailtoUrl(NS_CONST_CAST(char*, searchPart.get()));
run ,it will parse mailtourl object,if the url have "to",it will append a "," 
and a mail address to m_topart,but now m_topart did not been cut some redundant 
words,for example error is

m_toPart = [e-mail]?to=[e-mail]&body=sd
ParseMailtoUrl(NS_CONST_CAST(char*, searchPart.get())); finish
m_toPart = [e-mail]?to=[e-mail]&body=sd,[e-mail]
m_toPart.Cut(startOfSearchPart, numExtraChars); run
it will have some error!because now m_toPart had been appended some words.

Comment 6

[Jean-Francois Ducarroz]

Comment on attachment 78316 [details] [diff] [review]
this is a new patch for this bug,please rv my patch

Looks fine to me. R=ducarroz

Comment 7

[Antonio.Xu]

Who can super rv my patch?Thank you.

Comment 8

[(not reading, please use [e-mail] instead)]

we'll end up with:

       m_toPart.Cut(startOfSearchPart, numExtraChars);
       // now we need to strip off the search part from the
       // to part....
       ParseMailtoUrl(NS_CONST_CAST(char*, searchPart.get()));

is the comment now in the wrong place?

Comment 9

[Antonio.Xu]

Attachment: new patch for changing the comment's place,please rv

Thanks for Sspitzer's advice,i had changed the comment place,please rv my
patch.Thank you

Comment 10

[David :Bienvenu]

I think what Seth meant is that the comment :

       // now we need to strip off the search part from the
       // to part....

should be before the line that does what the comment says, which I believe is 
        m_toPart.Cut(startOfSearchPart, numExtraChars);

so, it should look like this:
       // now we need to strip off the search part from the
       // to part....
        m_toPart.Cut(startOfSearchPart, numExtraChars);
       ParseMailtoUrl(NS_CONST_CAST(char*, searchPart.get()));

Comment 11

[Antonio.Xu]

Attachment: hi mailnew's man,this is a new patch for this bug,a change comment's place again

please give me super rv ,thank you,it is really long time.

Comment 12

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 13

[(not reading, please use [e-mail] instead)]

fix landed on trunk.  thanks to [e-mail] for the fix.

sorry for the delay, we've been busy with RC1.

Comment 14

[Antonio.Xu]

thanks for your help!

Comment 15

[Antonio.Xu]

patch checked in NETSCAPE_7_0_OEM_BRANCH 

Comment 16

[Daniel Veditz [:dveditz]]

*** Bug 180397 has been marked as a duplicate of this bug. ***