Closed Bug 1359865 Opened 3 years ago Closed 2 years ago

Don't show Clipboard bar for URLs that are already open in a tab

Categories

(Firefox for iOS :: General, enhancement, P3)

All
iOS
enhancement

Tracking

()

RESOLVED FIXED
Iteration:
1.28
Tracking Status
fxios 9.0 ---
fxios-v8.0 --- affected

People

(Reporter: rnewman, Assigned: jhugman, Mentored)

References

Details

(Whiteboard: [MobileCore][ClipboardBar][papercut])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
garvan
: review+
Details | Review
Case 1:

Copy the page URL, background Firefox, and come back -- you get a toast offering to open the current page.

Case 2:

3D Touch the app icon and choose "Go to copied link".

Firefox opens, and offers to go to the copied link. Then the tab opens and the toast goes away.

Cases 3..N:

I expect this happens for links opened from Outlook or queued with View Later, too.

We should check whether we already have open, or are about to open, the copied link *before* we show the toast.
Mentor: sleroux
Priority: -- → P3
Attached file Pull Request
Attachment #8865276 - Flags: review?(sarentz)
Whiteboard: [papercut]
Attachment #8865276 - Flags: review?(sarentz) → review?(gkeeley)
Attachment #8865276 - Flags: review?(gkeeley) → review+
Landed: https://github.com/mozilla-mobile/firefox-ios/commit/9f2a311102759e2f95a5a951b02ece110e007a2c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Just reopening this because it needs to be uplifted to 8.x
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [papercut] → [MobileCore][ClipboardBar][papercut][needsuplift]
Summary: Don't show "Open copied link" toast for open or opening pages → Don't show Clipboard bar for URLs that are already open in a tab
Assignee: nobody → jhugman
Iteration: --- → 1.28
Landed on v9.x as 9f2a31110.
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][ClipboardBar][papercut][needsuplift] → [MobileCore][ClipboardBar][papercut]
See Also: → 1396834
You need to log in before you can comment on or make changes to this bug.