Closed Bug 1359892 Opened 2 years ago Closed 2 years ago

[Form Autofill] Support full-name fields

Categories

(Toolkit :: Form Manager, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill:M2])

Attachments

(1 file)

Create a single "name" field based on the separated name fields.
Assignee: nobody → lchang
Status: NEW → ASSIGNED
Comment on attachment 8862646 [details]
Bug 1359892 - [Form Autofill] Support full-name fields.

https://reviewboard.mozilla.org/r/134500/#review137784

::: browser/extensions/formautofill/ProfileStorage.jsm:349
(Diff revision 1)
>        }
>      }
>    },
>  
> +  _normalizeName(profile) {
> +    if (profile["name"]) {

Do an early return in the inverse case instead

::: browser/extensions/formautofill/test/unit/test_profileAutocompleteResult.js:6
(Diff revision 1)
>    guid: "test-guid-1",
> -  "given-name": "Timothy",
> +  name: "Timothy Berners-Lee",
> -  "family-name": "Berners-Lee",
>    organization: "Sesame Street",
>    "street-address": "123 Sesame Street.",
>    tel: "1-345-345-3456.",
>  }, {
>    guid: "test-guid-2",
> -  "given-name": "John",
> +  name: "John Doe",
> -  "family-name": "Doe",
>    organization: "Mozilla",
>    "street-address": "331 E. Evelyn Avenue",

Should we keep some test cases for the name parts?
Attachment #8862646 - Flags: review?(MattN+bmo) → review+
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5891c204981
[Form Autofill] Support full-name fields. r=MattN
https://hg.mozilla.org/mozilla-central/rev/d5891c204981
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.