1359892 - [Form Autofill] Support full-name fields

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement, P3)

Description

[Luke Chang [:lchang] (inactive)]

Create a single "name" field based on the separated name fields.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1359892 - [Form Autofill] Support full-name fields.

Review commit: https://reviewboard.mozilla.org/r/134500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134500/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8862646 [details]
Bug 1359892 - [Form Autofill] Support full-name fields.

https://reviewboard.mozilla.org/r/134500/#review137784

::: browser/extensions/formautofill/ProfileStorage.jsm:349
(Diff revision 1)
>        }
>      }
>    },
>  
> +  _normalizeName(profile) {
> +    if (profile["name"]) {

Do an early return in the inverse case instead

::: browser/extensions/formautofill/test/unit/test_profileAutocompleteResult.js:6
(Diff revision 1)
>    guid: "test-guid-1",
> -  "given-name": "Timothy",
> +  name: "Timothy Berners-Lee",
> -  "family-name": "Berners-Lee",
>    organization: "Sesame Street",
>    "street-address": "123 Sesame Street.",
>    tel: "1-345-345-3456.",
>  }, {
>    guid: "test-guid-2",
> -  "given-name": "John",
> +  name: "John Doe",
> -  "family-name": "Doe",
>    organization: "Mozilla",
>    "street-address": "331 E. Evelyn Avenue",

Should we keep some test cases for the name parts?

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8862646 [details]
Bug 1359892 - [Form Autofill] Support full-name fields.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/134500/diff/1-2/

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8862646 [details]
Bug 1359892 - [Form Autofill] Support full-name fields.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/134500/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5891c204981
[Form Autofill] Support full-name fields. r=MattN

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d5891c204981