If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

convert equality assertions against PR_GetCurrentThread to use NS_ASSERT_OWNINGTHREAD instead

NEW
Unassigned

Status

()

Core
General
5 months ago
2 months ago

People

(Reporter: froydnj, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 affected)

Details

(Reporter)

Description

5 months ago
The OWNINGTHREAD version is shorter and makes future changes to how owning thread assertions work much easier.

Undecided whether filing dependent bugs on this would be easier, or just doing all the work here would be easier.
status-firefox55: --- → affected
status-firefox57: affected → ---
Maybe we could just have a few sub-bugs by directory. The main directories that I see showing up are dom, netwerk, and xpcom. I'll file these tomorrow unless you get to it first.

I realized we also should do something about things like:
  MOZ_ASSERT(PR_GetCurrentThread() == gSocketThread);
Maybe we could just have a custom thing inside netwerk for that.
Flags: needinfo?(wmccloskey)
(Reporter)

Updated

5 months ago
Depends on: 1360236
(Reporter)

Comment 2

5 months ago
I have some patches for a few things in DOM.  While some are straightforward, some of them are definitely not. :(
(Reporter)

Updated

5 months ago
Depends on: 1360538
(Reporter)

Updated

5 months ago

Updated

5 months ago
Flags: needinfo?(wmccloskey)
(In reply to Nathan Froyd [:froydnj] from comment #2)
> I have some patches for a few things in DOM.  While some are
> straightforward, some of them are definitely not. :(

I could take care the one in dom/indexedDB and dom/filehandle if you haven't done it.
Depends on: 1366647
(Reporter)

Comment 4

4 months ago
(In reply to Bevis Tseng[:bevis][:btseng] from comment #3)
> (In reply to Nathan Froyd [:froydnj] from comment #2)
> > I have some patches for a few things in DOM.  While some are
> > straightforward, some of them are definitely not. :(
> 
> I could take care the one in dom/indexedDB and dom/filehandle if you haven't
> done it.

That would be fantastic, thank you!

Updated

2 months ago
Depends on: 1384395
You need to log in before you can comment on or make changes to this bug.