Closed
Bug 1359967
Opened 8 years ago
Closed 6 years ago
"self not defined" in oauthConnect method
Categories
(Calendar :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
6.5
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file)
1.09 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #682474 +++
I keep seeing a "self not defined" error.
I'm didn't investigate exactly what problem it causes, but the fix is pretty clear.
Apparently this code was added in bug 682474
Attachment #8862120 -
Flags: review?(philipp)
Comment 1•8 years ago
|
||
Comment on attachment 8862120 [details] [diff] [review]
bugXXX_self_not_defined.patch
Review of attachment 8862120 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the patch! I don't know how I missed that.
Attachment #8862120 -
Flags: review?(philipp) → review+
Updated•8 years ago
|
Attachment #8862120 -
Flags: approval-calendar-beta+
Attachment #8862120 -
Flags: approval-calendar-aurora+
Comment 2•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/f41d24c7cdde0697e9c3e029705e80493ea4be50
https://hg.mozilla.org/releases/comm-beta/rev/71dde03413c7e8d31bcbba342ab87f8251a73bbb
I didn't push to aurora because we've basically removed it, let me know if this is wrong.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 3•8 years ago
|
||
Yes, and please remove the Aurora approval.
BTW, it would have been better to let me handle the landings since I have some lined up in the next few hours.
Comment 4•8 years ago
|
||
Comment on attachment 8862120 [details] [diff] [review]
bugXXX_self_not_defined.patch
I understand, but Wayne was looking to build beta so I took care of this one. Thanks for helping out!
Attachment #8862120 -
Flags: approval-calendar-aurora+
Updated•8 years ago
|
Target Milestone: --- → 5.5
Comment 6•8 years ago
|
||
This depends on bug 682474 which hasn't been uplifted to ESR yet.
Comment 7•8 years ago
|
||
That should be fine, this doesn't need uplift to ESR until bug 682474 is uplifted.
Comment 8•8 years ago
|
||
Comment on attachment 8862120 [details] [diff] [review]
bugXXX_self_not_defined.patch
a+ since you requested approval for the dependent patch
Attachment #8862120 -
Flags: approval-calendar-esr+
Comment 9•8 years ago
|
||
TB 52 ESR, Calendar 5.4.x:
https://hg.mozilla.org/releases/comm-esr52/rev/2e1b58d59899
Target Milestone: 5.5 → 5.4.2
Comment 10•7 years ago
|
||
TB 52 ESR - Backout:
https://hg.mozilla.org/releases/comm-esr52/rev/762c13339d3d90f0b944e00850da059a58780801
Target Milestone: 5.4.2 → 5.5
Assignee | ||
Comment 11•7 years ago
|
||
I doubt this caused the gmail problems. What the backout means is basically caldav oauth won't connect so you probably broke calendar authentication. (At least for some cases, didn't look exactly how this is used.)
I suggest to add this back on esr.
Flags: needinfo?(jorgk)
Comment 12•7 years ago
|
||
This got backed out at part of backing out bug 682474. Quoting Phillip's e-mail on tb-drivers:
Jörg:
> do I back out bug 1176399 alone or also bug 682474 and
> bug 1359967.
Philipp:
They are connected, so you'd have to back them all out.
Flags: needinfo?(jorgk)
Assignee | ||
Comment 13•7 years ago
|
||
Ah, I see. But 682474 caused this but that got backed out.
Comment 14•7 years ago
|
||
Beta (TB 55, Calendar 5.7) backout:
https://hg.mozilla.org/releases/comm-beta/rev/e927b799e817d3b3066f166077541ca986fa902e
Target Milestone: 5.5 → 5.8
Comment 15•7 years ago
|
||
Backout from trunk:
https://hg.mozilla.org/comm-central/rev/74c3098a32249610e77573a56c920f9f92a55830
Sorry, I had to back this out since the next merge date is coming and I can't continue to back it out from all the betas we ship.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 5.8 → ---
Assignee | ||
Comment 16•6 years ago
|
||
This got relanded together with other stuff at some point.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 6 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Target Milestone: --- → 6.5
You need to log in
before you can comment on or make changes to this bug.
Description
•