Closed Bug 1359968 Opened 3 years ago Closed 3 years ago

Make non-cross clang 3.9.0 a public tooltool artifact

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: wcosta, Assigned: wcosta)

References

Details

Attachments

(1 file)

There is no reason to make this artifact internal.
Blocks: 1358533
For posterity, this is the file listed in browser/config/tooltool-manifests/macosx64/releng.manifest, currently:

 {
    "version": "clang 3.9.0",
    "size": 184678304,
    "digest": "cfde9a0f7f59823200f94422b4adb9a2fb5d4d07f240bbd1142c792434f6a1cbb4096d25c9853d77008fc40db0d827daa7003e78016f51241f621d6040ccc635",
    "algorithm": "sha512",
    "filename": "clang.tar.bz2",
    "unpack": true
  },

My guess is glandium accidentally didn't mark it as public when he uploaded it since you need to specify --visibility=public when populating the tooltool manifest.
FTR, the usernames in the original tar file say it wasn't glandium who created it. So I may have cast blame where it wasn't deserved. If so, I'm sorry.
Oh, thanks. Garbas was looking it making visibility change possible. How did you come up with a different digest? My previous attempt to re-upload failed because of digest collision.
Comment on attachment 8862933 [details]
Bug 1359968 - Re-upload clang 3.9 archive as a public tooltool artifact;

https://reviewboard.mozilla.org/r/134814/#review138136
Attachment #8862933 - Flags: review?(mshal) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f27bc1409fd6
Re-upload clang 3.9 archive as a public tooltool artifact; r=mshal
(In reply to Wander Lairson Costa [:wcosta] from comment #4)
> Oh, thanks. Garbas was looking it making visibility change possible. How did
> you come up with a different digest? My previous attempt to re-upload failed
> because of digest collision.

I unpacked the archive and repacked it. My username leaked into the archive, causing divergence.

(I can't wait for these archives to be built by taskcluster and part of the task graph.)
https://hg.mozilla.org/mozilla-central/rev/f27bc1409fd6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1363110
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.