1359968 - Make non-cross clang 3.9.0 a public tooltool artifact

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wander Lairson Costa]

There is no reason to make this artifact internal.

Comment 1

[Gregory Szorc [:gps]]

For posterity, this is the file listed in browser/config/tooltool-manifests/macosx64/releng.manifest, currently:

 {
    "version": "clang 3.9.0",
    "size": 184678304,
    "digest": "cfde9a0f7f59823200f94422b4adb9a2fb5d4d07f240bbd1142c792434f6a1cbb4096d25c9853d77008fc40db0d827daa7003e78016f51241f621d6040ccc635",
    "algorithm": "sha512",
    "filename": "clang.tar.bz2",
    "unpack": true
  },

My guess is glandium accidentally didn't mark it as public when he uploaded it since you need to specify --visibility=public when populating the tooltool manifest.

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1359968 - Re-upload clang 3.9 archive as a public tooltool artifact;

The old archive was uploaded with internal visibility. This was almost
certainly a mistake.

I downloaded the old archive and produced a new one and re-uploaded it to
tooltool with public visibility. I had to reproduce the archive because
tooltool won't let you promote an existing item to public.

It appears that environment state and possibly differences in the
tar command result in diverging tar archives. For example:

==> clang.orig <==
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/bin/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/include/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/lib/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/libexec/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/share/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/share/clang/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/share/man/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/share/scan-build/
drwxr-xr-x ehsan/wheel       0 2017-02-01 20:34 clang/share/scan-view/

==> clang.new <==
drwxr-xr-x gps/gps           0 2017-02-01 20:34 clang/
drwxr-xr-x gps/gps           0 2017-02-01 20:34 clang/bin/
-rwxr-xr-x gps/gps       18099 2017-02-01 20:15 clang/bin/git-clang-format
-rwxr-xr-x gps/gps     6731340 2017-02-01 20:33 clang/bin/llvm-mc
-rwxr-xr-x gps/gps     2241688 2017-02-01 20:34 clang/bin/obj2yaml
-rwxr-xr-x gps/gps    17105264 2017-02-01 20:33 clang/bin/llvm-c-test
-rwxr-xr-x gps/gps    13153616 2017-02-01 20:33 clang/bin/bugpoint
-rwxr-xr-x gps/gps    49666672 2017-02-01 20:33 clang/bin/clang-3.9
-rwxr-xr-x gps/gps       52901 2017-02-01 20:15 clang/bin/scan-build
-rwxr-xr-x gps/gps     6214036 2017-02-01 20:30 clang/bin/llvm-ar

Content within should be identical. It's just the file ordering and
owner bits that are different. This shouldn't matter.

Review commit: https://reviewboard.mozilla.org/r/134814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134814/

Comment 3

[Gregory Szorc [:gps]]

FTR, the usernames in the original tar file say it wasn't glandium who created it. So I may have cast blame where it wasn't deserved. If so, I'm sorry.

Comment 4

[Wander Lairson Costa]

Oh, thanks. Garbas was looking it making visibility change possible. How did you come up with a different digest? My previous attempt to re-upload failed because of digest collision.

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8862933 [details]
Bug 1359968 - Re-upload clang 3.9 archive as a public tooltool artifact;

https://reviewboard.mozilla.org/r/134814/#review138136

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f27bc1409fd6
Re-upload clang 3.9 archive as a public tooltool artifact; r=mshal

Comment 7

[Gregory Szorc [:gps]]

(In reply to Wander Lairson Costa [:wcosta] from comment #4)
> Oh, thanks. Garbas was looking it making visibility change possible. How did
> you come up with a different digest? My previous attempt to re-upload failed
> because of digest collision.

I unpacked the archive and repacked it. My username leaked into the archive, causing divergence.

(I can't wait for these archives to be built by taskcluster and part of the task graph.)

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f27bc1409fd6