1360082 - detail is not visible for bare json strings in response viewer

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[echo]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170418123106

Steps to reproduce:

1. Open the developer tools.
2. Make a request that returns content-type application/json and has a body of a quoted string by itself. I've put this up for testing: https://jc6e81at9k.execute-api.us-west-2.amazonaws.com/dev/jsonstring
3. Click on the network tab, then the request you just made, then the response tab.


Actual results:

It's blank, showing only the word "JSON" that always appears at the top.


Expected results:

It should show the string returned. A bare quoted string is perfectly valid JSON. JSON.stringify will produce one, and JSON.parse will accept one.

(I reported this against 54, but it's not actually new.)

Comment 1

[YF (Yang)]

It exists but is almost invisible because it is almost white:
color: rgb(245, 247, 250);

tree-view.css:79
.treeTable .treeRow.selected:not(:hover) *
var(--theme-selection-color)


If set devtools use dark theme, it is visible.

Comment 2

[YF (Yang)]

(In reply to YF (Yang) from comment #1)
> It exists but is almost invisible because it is almost white:
> color: rgb(245, 247, 250);
> 
> tree-view.css:79
> .treeTable .treeRow.selected:not(:hover) *
> var(--theme-selection-color)
> 
> 
> If set devtools use dark theme, it is visible.

Seem not for Firefox 54, white text for Fx55 and Nightly 56.

Comment 3

[Xavier ALT [:dex]]

Hi, I would like to work on this one.

Comment 4

[Xavier ALT [:dex]]

Attachment: Bug 1360082 - Network monitor: use devtools theme alt color for bare json strings in response viewer

Review commit: https://reviewboard.mozilla.org/r/170470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170470/

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8899199 [details]
Bug 1360082 - Network monitor: use devtools theme alt color for bare json strings in response viewer

https://reviewboard.mozilla.org/r/170470/#review177412

Works for me, thanks for the patch!

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfce5393f345
Network monitor: use devtools theme alt color for bare json strings in response viewer r=Honza

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bfce5393f345

Comment 8

[Sylvestre Ledru [:Sylvestre]]

We probably want this to ride the train.