1360095 - Intermittent uriloader/exthandler/tests/mochitest/browser_auto_close_window.js | window was opened and closed - Got false, expected true

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=94725435&repo=autoland

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-macosx64/1493262145/autoland_yosemite_r7_test-mochitest-e10s-browser-chrome-2-bm132-tests1-macosx-build206.txt.gz

Comment 1

[Intermittent Failures Robot]

5 failures in 883 pushes (0.006 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 2
* autoland: 2
* try: 1

Platform breakdown:
* osx-10-10: 3
* windows8-64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1360095&startday=2017-04-24&endday=2017-04-30&tree=all

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This is now happening on Beta as of the latest push there, which is making me suspect it was caused by bug 1357407. The timing appears to fit for trunk too at a glance.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The change in bug 1357407 is for Marionette only, and this harness is only used to install addons for Mochitests. I don't see why this should have an effect here, especially it also only adds code for logging which has nothing to do with window handling.

Comment 4

[Intermittent Failures Robot]

27 failures in 770 pushes (0.035 failures/push) were associated with this bug in the last 7 days. 

This is the #39 most frequent failure this week.  

Repository breakdown:
* mozilla-inbound: 10
* mozilla-beta: 8
* autoland: 7
* mozilla-central: 2

Platform breakdown:
* windows8-64: 11
* windows7-32-vm: 7
* osx-10-10: 7
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1360095&startday=2017-05-01&endday=2017-05-07&tree=all

Comment 5

[Geoff Brown [:gbrown]]

This is a relatively new test, added in bug 1359651, on central 2017-04-27 and on beta 2017-05-01.

Comment 6

[Intermittent Failures Robot]

39 failures in 879 pushes (0.044 failures/push) were associated with this bug in the last 7 days. 

This is the #35 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 17
* autoland: 15
* mozilla-beta: 3
* mozilla-central: 2
* try: 1
* graphics: 1

Platform breakdown:
* windows8-64: 23
* windows7-32-vm: 8
* osx-10-10: 5
* linux64: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1360095&startday=2017-05-08&endday=2017-05-14&tree=all

Comment 7

[Geoff Brown [:gbrown]]

Always e10s (skipped on non-e10s) and mostly windows and debug, but all platforms are affected.

:mrbkap - Can you make this test more reliable?

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1360095 - Wait for the window to close before checking that it does.

The external helper app service waits for a second before closing the window,
which could lead to races. Also wait for the tab to close to avoid similar
races, there.

Review commit: https://reviewboard.mozilla.org/r/140380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140380/

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8868789 [details]
Bug 1360095 - Wait for the window to close before checking that it does.

https://reviewboard.mozilla.org/r/140380/#review144364

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8358de87720b
Wait for the window to close before checking that it does. r=Felipe

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8358de87720b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eedfc71718b4

Comment 13

[Intermittent Failures Robot]

18 failures in 777 pushes (0.023 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 7
* autoland: 5
* mozilla-beta: 4
* mozilla-central: 1
* graphics: 1

Platform breakdown:
* windows8-64: 8
* osx-10-10: 5
* windows7-32-vm: 3
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1360095&startday=2017-05-15&endday=2017-05-21&tree=all