1360112 - Correct background image position

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

According to the test failures [1] (background-repeat-space-1b.html), looks like I missed some calculations for the image position.

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/bcFFpERLQM2S-w27Qjiqog/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 1

[Ethan Lin[:ethlin]]

Attachment: correct position

I should calculate firstTilePos[1] for the top-left or the image will be blocked by the border.

[1] https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#6765

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Rebased to graphics tip

I changed some of this code to be strongly typed and to stop using NSRectToRect on the graphics branch (in bug 1359842). I rebased your patch on top of my changes - I thought it might be complicated but it turned out to be pretty simple. Attaching it here since I already did the work.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8862303 [details] [diff] [review]
correct position

Review of attachment 8862303 [details] [diff] [review]:
-----------------------------------------------------------------

Can you move the nsLayoutUtils code into a public helper and then just use that in both places?

Comment 4

[Ethan Lin[:ethlin]]

Attachment: correct position

I only need the code of firstTilePos. Could I just create a static function to retrieve the firstTilePos?

Comment 5

[Ethan Lin[:ethlin]]

Try result is good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=082090ea42ea761d92157f4444a6691db029353f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/eb77f99d677f
Correct background image position when enabling webrender background image. r=mattwoodrow

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/eb77f99d677f