Closed Bug 1360112 Opened 2 years ago Closed 2 years ago

Correct background image position

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

Attachments

(2 files, 1 obsolete file)

Blocks: 1359242
Attached patch correct position (obsolete) — Splinter Review
I should calculate firstTilePos[1] for the top-left or the image will be blocked by the border.

[1] https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#6765
Attachment #8862303 - Flags: review?(matt.woodrow)
I changed some of this code to be strongly typed and to stop using NSRectToRect on the graphics branch (in bug 1359842). I rebased your patch on top of my changes - I thought it might be complicated but it turned out to be pretty simple. Attaching it here since I already did the work.
Comment on attachment 8862303 [details] [diff] [review]
correct position

Review of attachment 8862303 [details] [diff] [review]:
-----------------------------------------------------------------

Can you move the nsLayoutUtils code into a public helper and then just use that in both places?
Attached patch correct positionSplinter Review
I only need the code of firstTilePos. Could I just create a static function to retrieve the firstTilePos?
Attachment #8862303 - Attachment is obsolete: true
Attachment #8862303 - Flags: review?(matt.woodrow)
Attachment #8862717 - Flags: review?(matt.woodrow)
Attachment #8862717 - Flags: review?(matt.woodrow) → review+
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/eb77f99d677f
Correct background image position when enabling webrender background image. r=mattwoodrow
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.