Closed Bug 1360140 Opened 2 years ago Closed 2 years ago

Add Learn More link for the "Use recommended performance settings" checkbox

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox55 --- verified

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Add Learn More link for the "Use recommended performance settings" checkbox. The design spec is [1].

[1]: https://mozilla.invisionapp.com/share/C2B97CAYH#/screens/230367023
Flags: qe-verify+
QA Contact: hani.yacoub
Priority: -- → P2
Target Milestone: --- → Firefox 55
Assignee: nobody → evan
Status: NEW → ASSIGNED
Priority: P2 → P1
Received an email from Joni Savage. The URL is `https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/performance`. But now the content is empty. She will work on that on Bug 1359735.
Mike's review queue maxed out, and Jared is on PTO. We might need to wait for some time and continue to review the patch.
Attachment #8864519 - Flags: review?(mconley)
Comment on attachment 8864519 [details]
Bug 1360140 - Add Learn More link for the Use recommended performance settings checkbox

https://reviewboard.mozilla.org/r/136200/#review140374

Feels kind of strange to have the same "Learn more" duplicated in multiple places, and having different keys. Oh well.

::: browser/locales/en-US/chrome/browser/preferences/advanced.dtd:136
(Diff revision 2)
>  <!ENTITY useRecommendedPerformanceSettings.description
>                                           "Recommended performance settings are tailored to your computer.">
>  <!ENTITY useRecommendedPerformanceSettings.accesskey
>                                           "U">
> +<!ENTITY performanceSettingsLearnMore.label
> +                                         "Learn More">

The design spec has the "M" in "More" lowercased.
Attachment #8864519 - Flags: review?(mconley) → review+
(In reply to Mike Conley (:mconley) - At work week, slow to respond from comment #6)
> Comment on attachment 8864519 [details]
> Bug 1360140 - Add Learn More link for the Use recommended performance
> settings checkbox
> 
> https://reviewboard.mozilla.org/r/136200/#review140374
> 
> Feels kind of strange to have the same "Learn more" duplicated in multiple
> places, and having different keys. Oh well.

I agree, that is kind of strnage. I think we only should have one key for "Learn more" string. How about we file a follow up bug to address that?
Flags: needinfo?(mconley)
Let's land the patch after the treeherder task[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0019ac0ecef8
And thanks Mike for reviewing.
(In reply to Evan Tseng [:evanxd] from comment #8)
> I agree, that is kind of strnage. I think we only should have one key for
> "Learn more" string. How about we file a follow up bug to address that?

Sounds good.
Flags: needinfo?(mconley)
See Also: → 1363463
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e122fba32bf8
Add Learn More link for the Use recommended performance settings checkbox r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e122fba32bf8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Learn More link for the "Use recommended performance settings" checkbox has been implemented with Latest Nightly 55.0a1 on Windows 8.1 (64 bit).

Build ID :  20170608030205
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170607]
This bug was about adding Learn More link for the "Use recommended performance settings" checkbox and I have seen the feature being implemented with latest Nightly on Ubuntu 16.04 LTS!

Build ID   :  20170613100218
User Agent :  Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170614]
As per comment 14 & comment 15, I am making this bug's status as verified fixed!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.