1360153 - Scheduled deletion: Show the data of the rule being deleted, instead of its new state

Status: RESOLVED DUPLICATE of bug 1363452

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P3)

Description

[Johan Lorenzo [:jlorenzo]]

At the moment, when you schedule a deletion for a rule, you see the new state of the data, which is full of None values. Because of that, the front end doesn't show much about what's being deleted on [1].

This led to a human error: even though somebody reviewed my changes on [1], I deleted a rule in which the comment read "DO NOT DELETE".

Like :bhearsum suggested over email, we should better display the current data of the rule for deletion.

[1] https://aus4-admin.mozilla.org/rules/scheduled_changes

Comment 1

[[e-mail] (:bhearsum)]

Something similar came up in the post mortem yesterday when we were talking about using Scheduled Changes/Required Signoffs as a review system for Balrog changes. Lawrence made the suggestion that showing "what changed" might be very helpful for that case, and it makes me wonder if we can improve the Scheduled Change UI more generally by doing that for all change types. Maybe use something like "release* -> release" for changed values, and use what we have now for unchanged values. Longer fields like OS_VERSION might need something else to avoid uglyness.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Obinna brought this bug to my attention. It turns the diff view has already been implemented in bug 1363452. This makes our lives easier. We can close this bug.