1360162 - UpdateOverlayTextVisibility is called twice by input.value setter when input element has focus

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

UpdateOverlayTextVisibility uses OutputToString that is expensive.  We should add fast path to check whether empty or not (Bug 1360154).

UpdateOverlayTextVisibility() is called from EditorBase::NotifyEditorObserver() via EndPlaceHolderTransaction().  But nsTextEditorState::SetValue is also called UpdateOverlayTextVisibility() via ValueWasChanged.

So it is unnecessary to call UpdateOverlayTextVisibility when editor already calls UpdateOverlayTextVisibility.

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f320e82c7b5f244934c9fe0a9e19627495f857f

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1360162 - Don't call UpdateOverlayTextVisibility twice by input.value setter when input element has focus.

When editor has focus, input.value setter will call UpdateOverlayTextVisibility via nsTextInputListener::EditAction -> nsTextControlFrame::SetValueChanged at first.  But SetValue will call UpdateOverlayTextVisibility again via ValueWasChanged.

So it is unnecessary to call UpdateOverlayTextVisibility on nsTextEditorState::SetValue when we have the editor.

Review commit: https://reviewboard.mozilla.org/r/151590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151590/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8880236 [details]
Bug 1360162 - Don't call UpdateOverlayTextVisibility twice by input.value setter when input element has focus.

https://reviewboard.mozilla.org/r/151590/#review156588

::: dom/html/nsTextEditorState.cpp:2696
(Diff revision 1)
>            mTextListener->SetValueChanged(true);
>            mTextListener->SettingValue(false);
> +
> +          if (!notifyValueChanged) {
> +            // Listener doesn't update frame, but it is required for placeholder
> +            ValueWasChanged(true);
> +          }

Hmm, really tricky code... This can be regressed again easily. However, I have no better idea to fix this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c36dabb0aba6
Don't call UpdateOverlayTextVisibility twice by input.value setter when input element has focus. r=masayuki

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c36dabb0aba6