Closed Bug 1360163 Opened 3 years ago Closed 3 years ago

Add test for altData of cache index

Categories

(Core :: Networking: Cache, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: junior, Assigned: junior)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch test-alt - v1 (obsolete) — Splinter Review
Expose the index attributes to js, so we can test the existence of alt data from cache index.
Attachment #8862765 - Flags: review?(valentin.gosu)
Attachment #8862765 - Flags: review?(valentin.gosu) → review?(michal.novotny)
Comment on attachment 8862765 [details] [diff] [review]
test-alt - v1

Review of attachment 8862765 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: netwerk/cache2/CacheStorage.h
@@ -72,5 @@
>    bool WriteToDisk() const { return mWriteToDisk && !mLoadContextInfo->IsPrivate(); }
>    bool LookupAppCache() const { return mLookupAppCache; }
>    bool SkipSizeCheck() const { return mSkipSizeCheck; }
>    bool Pinning() const { return mPinning; }
> -  virtual nsresult GetCacheIndexEntryAttrs(

You should probably also replace nsresult with NS_IMETHODIMP in cpp file.
Attachment #8862765 - Flags: review?(michal.novotny) → review+
Attached patch test-alt - v2 (obsolete) — Splinter Review
modify by last comment and carry r+
Attachment #8862765 - Attachment is obsolete: true
Attachment #8863969 - Flags: review+
Attached patch test-alt -v3Splinter Review
Fix bustage (child process can't get cache index), carry r+
Attachment #8863969 - Attachment is obsolete: true
Attachment #8864424 - Flags: review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b5df4f239de
Add test for altData of cache index, r=michal
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2b5df4f239de
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.