1360163 - Add test for altData of cache index

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement)

Comment 1

[Junior [inactive]]

Attachment: test-alt - v1

Expose the index attributes to js, so we can test the existence of alt data from cache index.

Comment 2

[Michal Novotny [:michal]]

Comment on attachment 8862765 [details] [diff] [review]
test-alt - v1

Review of attachment 8862765 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: netwerk/cache2/CacheStorage.h
@@ -72,5 @@
>    bool WriteToDisk() const { return mWriteToDisk && !mLoadContextInfo->IsPrivate(); }
>    bool LookupAppCache() const { return mLookupAppCache; }
>    bool SkipSizeCheck() const { return mSkipSizeCheck; }
>    bool Pinning() const { return mPinning; }
> -  virtual nsresult GetCacheIndexEntryAttrs(

You should probably also replace nsresult with NS_IMETHODIMP in cpp file.

Comment 3

[Junior [inactive]]

Attachment: test-alt - v2

modify by last comment and carry r+

Comment 4

[Junior [inactive]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbae8e117cbef1163b768bb211d80d55e5251dd1

Comment 5

[Junior [inactive]]

Attachment: test-alt -v3

Fix bustage (child process can't get cache index), carry r+

Comment 6

[Junior [inactive]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea2431966469287b9501d8e908759a708d43ce84

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b5df4f239de
Add test for altData of cache index, r=michal

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b5df4f239de