1360170 - Change Search Settings button is not blue/orange when selected using the UP/DOWN keys

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect, P3)

Description

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170426030329

[Affected versions]:
- Nightly 55.0a1

[Affected platforms]:
- All 

[Steps to reproduce]:
1. Launch Firefox 
2. Write something in the Search Bar
3. Press Up or Down keys to navigate in the Search panel

[Expected result]:
- You should start cycling through all the elements of the Search Panel (search suggestions, one-off buttons and Change Search Settings button) and all the elements should have the same color when selected (blue on Windows and Mac OS X and orange on Ubuntu).

[Actual result]:
- The Change Search settings button remains gray when selected. This is pretty confusing since the color of the buttons on mouse hover is also gray.
Please see the screencast for more details.

[Additional notes]:
- This issue is not specific only to the search bar, is also encountered in the about:home or new:tab pages.

Comment 1

[Simona Badau, Desktop QA]

Attachment: ChangeSearchSettings.mp4

Comment 2

[Drew Willcoxon :adw]

Thanks for filing this, but to be clear, I think this was always the case?  You can see by looking at the history of this line:

https://hg.mozilla.org/mozilla-central/annotate/1c6fa11d1fed893b00d94b6a899c307262674613/browser/themes/windows/searchbar.css#l337

So it's not related to bug 1295458, which is marked as depending on this bug.

Comment 3

[Drew Willcoxon :adw]

(In reply to Simona B [:simonab ] from comment #0)
> This is pretty confusing since the color of the buttons on mouse
> hover is also gray. Please see the screencast for more details.

Although maybe as you say, bug 1295458 made it worse.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

I think this might be a wontfix. The footer button is styled consistently in many places, e.g. the site identity panel or the downloads panel. Stephen, should the search panel footer (Change Search Settings) selected color be the same as the settings cog in the location bar one-offs (where it is not a footer) or the same as the other footer buttons (downloads, site identity panel)?

Comment 5

[Mark Banner (:standard8)]

In the latest Firefox all the buttons in the search bar now have a dark grey highlight, and they are consistent.