1360189 - improve autocompletion of mappings in rules UI

Status: RESOLVED WONTFIX

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P3)

Description

[[e-mail] (:bhearsum)]

We had an issue recently where we accidentally pointed a Firefox release channel rule at an ESR release. The UI "helpfully" autocompleted "Firefox-52.0.2" to "Firefox-52.0.2esr-build1", which was a contributing factor.

I'm not entirely certain how to do this effectively, because Releases currently have no sense of what "channel" they are associated with (and in fact, some Releases like RCs may validly ship to both the "beta" and "release" channels). One idea we tossed around was to add MAR_CHANNEL_ID to the Release table, and ignore any Releases whose MAR_CHANNEL_ID doesn't match the channel on the Rule being created/updated. We'd have to maintain this mapping somewhere. Even if we do this there may be some situations we need to be extra careful of. Eg: the release-to-esr MARs that currently existed have a MAR_CHANNEL_ID of firefox-mozilla-release, but we may want to find a way to avoid autocompleting them anyways beacuse of the impact if we ship them to the wrong users by mistake.

I don't think we want to fully disallow someone from making a change like this, but we definitely want to make it harder.

Comment 1

[[e-mail] (:bhearsum)]

Mass closure of old Balrog UI bugs. We've built a new UI in https://github.com/mozilla-frontend-infra/balrog-ui, and any issues which are still valid should be filed as Issues there.