1360293 - Enable the ESLint recommended rules for tools/

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Mark Banner (:standard8)]

I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely.

At the moment, tools/ doesn't inherit rules from the mozilla/recommended configuration, and so just gets a basic set.

The aim of this bug is to get tools/ passing mozilla/recommended and for it to be enabled by default.

Comment 1

[Dan Banner]

Attachment: Bug 1360293 - Enable the Mozilla ESlint recommended rules for tools/.

Review commit: https://reviewboard.mozilla.org/r/135116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135116/

Comment 2

[Nicholas Nethercote [inactive]]

I know nothing about ESLint and I rarely touch JS code, so I think I'm not the right person to review this. Looks like jryans has done ESList-related reviews before, though, so I will forward to him.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8863331 [details]
Bug 1360293 - Enable the Mozilla ESlint recommended rules for tools/.

https://reviewboard.mozilla.org/r/135116/#review138490

Thanks, everything looks good to me! :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdab5d37d343
Enable the Mozilla ESlint recommended rules for tools/. r=jryans

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cdab5d37d343