Enable the ESLint recommended rules for tools/

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: dbugs, Mentored)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely.

At the moment, tools/ doesn't inherit rules from the mozilla/recommended configuration, and so just gets a basic set.

The aim of this bug is to get tools/ passing mozilla/recommended and for it to be enabled by default.
status-firefox57: affected → ---
Comment hidden (mozreview-request)
I know nothing about ESLint and I rarely touch JS code, so I think I'm not the right person to review this. Looks like jryans has done ESList-related reviews before, though, so I will forward to him.
Attachment #8863331 - Flags: review?(n.nethercote) → review?(jryans)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8863331 [details]
Bug 1360293 - Enable the Mozilla ESlint recommended rules for tools/.

https://reviewboard.mozilla.org/r/135116/#review138490

Thanks, everything looks good to me! :)
Attachment #8863331 - Flags: review?(jryans) → review+

Comment 4

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cdab5d37d343
Enable the Mozilla ESlint recommended rules for tools/. r=jryans

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cdab5d37d343
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.