1360323 - getTabBrowser method shouldn't insert lazy browsers

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

From bug comment 1:

> Not sure if this is the right place for this, but another add-on triggering
> the message is BackTrack Tab History:
> 
> [bug 1345098] Lazy browser prematurely inserted via 'getTabBrowser' property
> access:
> getter@chrome://browser/content/tabbrowser.xml:2115:45
> getPersistentIDs@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/[e-mail]!/
> bootstrap.js:1243:15
> getAllTabPIDs/<@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/[e-mail]!/
> bootstrap.js:1106:30
> forEachTabBrowserOnEachWindow@resource://gre/modules/addons/XPIProvider.jsm
> ->
> jar:file:///D:/Downloads/debug/tmp/extensions/[e-mail]!/
> bootstrap.js:1424:21
> getAllTabPIDs@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/[e-mail]!/
> bootstrap.js:1104:5
> onSSTabClosing@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/[e-mail]!/
> bootstrap.js:1096:19
> ssi_onTabClose@resource:///modules/sessionstore/SessionStore.jsm:1930:5
> ssi_handleEvent@resource:///modules/sessionstore/SessionStore.jsm:1012:11
> _beginRemoveTab@chrome://browser/content/tabbrowser.xml:2765:13
> removeTab@chrome://browser/content/tabbrowser.xml:2632:18
> onxblclick@chrome://browser/content/tabbrowser.xml:6588:11

Comment 1

[u462496]

Attachment: 1360323_getTabBrowser_not_insert_browser_V1.diff

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8862585 [details] [diff] [review]
1360323_getTabBrowser_not_insert_browser_V1.diff

It would probably be a good idea to start sorting the switch cases alphabetically.

Comment 3

[u462496]

Attachment: 1360323_getTabBrowser_not_insert_browser_V2.diff

Alphabetize switch cases in _createLazyBrowser,

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d9f24863079
Implement getTabBrowser shim for lazy browsers. r=dao

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2d9f24863079