getTabBrowser method shouldn't insert lazy browsers

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dao, Assigned: u462496)

Tracking

Trunk
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
From bug comment 1:

> Not sure if this is the right place for this, but another add-on triggering
> the message is BackTrack Tab History:
> 
> [bug 1345098] Lazy browser prematurely inserted via 'getTabBrowser' property
> access:
> getter@chrome://browser/content/tabbrowser.xml:2115:45
> getPersistentIDs@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1243:15
> getAllTabPIDs/<@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1106:30
> forEachTabBrowserOnEachWindow@resource://gre/modules/addons/XPIProvider.jsm
> ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1424:21
> getAllTabPIDs@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1104:5
> onSSTabClosing@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1096:19
> ssi_onTabClose@resource:///modules/sessionstore/SessionStore.jsm:1930:5
> ssi_handleEvent@resource:///modules/sessionstore/SessionStore.jsm:1012:11
> _beginRemoveTab@chrome://browser/content/tabbrowser.xml:2765:13
> removeTab@chrome://browser/content/tabbrowser.xml:2632:18
> onxblclick@chrome://browser/content/tabbrowser.xml:6588:11
status-firefox57: affected → ---
(Assignee)

Comment 1

a year ago
Created attachment 8862585 [details] [diff] [review]
1360323_getTabBrowser_not_insert_browser_V1.diff
Attachment #8862585 - Flags: review?(dao+bmo)
(Assignee)

Updated

a year ago
Assignee: nobody → kevinhowjones
(Reporter)

Comment 2

a year ago
Comment on attachment 8862585 [details] [diff] [review]
1360323_getTabBrowser_not_insert_browser_V1.diff

It would probably be a good idea to start sorting the switch cases alphabetically.
Attachment #8862585 - Flags: review?(dao+bmo) → review+
(Assignee)

Comment 3

a year ago
Created attachment 8862809 [details] [diff] [review]
1360323_getTabBrowser_not_insert_browser_V2.diff

Alphabetize switch cases in _createLazyBrowser,
Attachment #8862585 - Attachment is obsolete: true
Attachment #8862809 - Flags: review?(dao+bmo)
(Reporter)

Updated

a year ago
Attachment #8862809 - Flags: review?(dao+bmo) → review+

Comment 4

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d9f24863079
Implement getTabBrowser shim for lazy browsers. r=dao
https://hg.mozilla.org/mozilla-central/rev/2d9f24863079
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.