Closed Bug 1360323 Opened 3 years ago Closed 3 years ago

getTabBrowser method shouldn't insert lazy browsers

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: dao, Assigned: u462496)

References

Details

Attachments

(1 file, 1 obsolete file)

From bug comment 1:

> Not sure if this is the right place for this, but another add-on triggering
> the message is BackTrack Tab History:
> 
> [bug 1345098] Lazy browser prematurely inserted via 'getTabBrowser' property
> access:
> getter@chrome://browser/content/tabbrowser.xml:2115:45
> getPersistentIDs@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1243:15
> getAllTabPIDs/<@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1106:30
> forEachTabBrowserOnEachWindow@resource://gre/modules/addons/XPIProvider.jsm
> ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1424:21
> getAllTabPIDs@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1104:5
> onSSTabClosing@resource://gre/modules/addons/XPIProvider.jsm ->
> jar:file:///D:/Downloads/debug/tmp/extensions/backtrack@byalexv.co.uk.xpi!/
> bootstrap.js:1096:19
> ssi_onTabClose@resource:///modules/sessionstore/SessionStore.jsm:1930:5
> ssi_handleEvent@resource:///modules/sessionstore/SessionStore.jsm:1012:11
> _beginRemoveTab@chrome://browser/content/tabbrowser.xml:2765:13
> removeTab@chrome://browser/content/tabbrowser.xml:2632:18
> onxblclick@chrome://browser/content/tabbrowser.xml:6588:11
Attachment #8862585 - Flags: review?(dao+bmo)
Assignee: nobody → kevinhowjones
Comment on attachment 8862585 [details] [diff] [review]
1360323_getTabBrowser_not_insert_browser_V1.diff

It would probably be a good idea to start sorting the switch cases alphabetically.
Attachment #8862585 - Flags: review?(dao+bmo) → review+
Alphabetize switch cases in _createLazyBrowser,
Attachment #8862585 - Attachment is obsolete: true
Attachment #8862809 - Flags: review?(dao+bmo)
Attachment #8862809 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d9f24863079
Implement getTabBrowser shim for lazy browsers. r=dao
https://hg.mozilla.org/mozilla-central/rev/2d9f24863079
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.