1360403 - Remove hackarounds in test_keyframes_vendor_prefix.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

We added a dummy rule in tests in test_keyframes_vendor_prefix.html to avoid single insertRule call problem.  Now the problem has been solved in bug 1336863. We can drop the dummy rule.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5b2432391ec2f5c469244b06934485e07c042c7

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1360403 - Remove no-longer-needed hackarounds for now-fixed insertRule problem on stylo.

The problem has been solved in bug 1336863.

Review commit: https://reviewboard.mozilla.org/r/134560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134560/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8862692 [details]
Bug 1360403 - Remove no-longer-needed hackarounds for now-fixed insertRule problem on stylo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/134560/diff/1-2/

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8862692 [details]
Bug 1360403 - Remove no-longer-needed hackarounds for now-fixed insertRule problem on stylo.

https://reviewboard.mozilla.org/r/134560/#review137744

::: commit-message-2cca3:1
(Diff revision 2)
> +Bug 1360403 - Remove hackarounds for insertRule problem on stylo. r?dholbert

Commit message tweak, to be slightly clearer:
 s/hackarounds/no-longer-needed hackarounds/

...or:
 s/for insertRule problem/for now-fixed insertRule problem/

...or something like that, to make it clear that the problem is addressed and that's why we're removing the hackarounds.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> Comment on attachment 8862692 [details]
> Bug 1360403 - Remove hackarounds for insertRule problem on stylo.
> 
> https://reviewboard.mozilla.org/r/134560/#review137744
> 
> ::: commit-message-2cca3:1
> (Diff revision 2)
> > +Bug 1360403 - Remove hackarounds for insertRule problem on stylo. r?dholbert
> 
> Commit message tweak, to be slightly clearer:
>  s/hackarounds/no-longer-needed hackarounds/
> 
> ...or:
>  s/for insertRule problem/for now-fixed insertRule problem/
> 
> ...or something like that, to make it clear that the problem is addressed
> and that's why we're removing the hackarounds.

Indeed! Thank you!

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8862692 [details]
Bug 1360403 - Remove no-longer-needed hackarounds for now-fixed insertRule problem on stylo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/134560/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/684c9e3c2540
Remove no-longer-needed hackarounds for now-fixed insertRule problem on stylo. r=dholbert

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/684c9e3c2540