Closed
Bug 1360554
Opened 8 years ago
Closed 8 years ago
import new version of devools-source-map
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file)
We'll need a new version of devtools-source-map for console source maps.
Also, devtools-source-map's startup API changed upstream, so I'll do this
in a separate bug.
The update should include https://github.com/devtools-html/devtools-core/pull/350
Assignee | ||
Comment 1•8 years ago
|
||
Upstream PR here: https://github.com/devtools-html/devtools-core/pull/351
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•8 years ago
|
||
The bundle files shrank quite a bit, so I'm not 100% sure I did everything correctly.
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8862926 [details]
Bug 1360554 - devtools-source-map v0.4.0: Update bundle from GitHub;
https://reviewboard.mozilla.org/r/134806/#review137760
Thanks, looks right to me! The previous version had accidentally included UI junk, so the smaller size is expected.
Attachment #8862926 -
Flags: review?(jryans) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c02896f0b46
devtools-source-map v0.4.0: Update bundle from GitHub; r=jryans
Following what reps seems to do, I created a meta bug to hold these bundle updates. Not sure if that's actually useful, but for now I'll mark this one...
Blocks: source-map-bundle-updates
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 8•8 years ago
|
||
as a note, this caused a perf regression on linux64 pgo only (not opt):
== Change summary for alert #6313 (as of May 01 2017 23:06 UTC) ==
Regressions:
2% damp summary linux64 pgo 244.04 -> 249.97
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=6313
this is a small regression and if it is pgo only, then I am less concerned as most regressions show up on opt and pgo.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•