1360567 - Add telemetry probes for Indexeddb storage types

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, enhancement, P2)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Following Bug 1354500 Comment 1:

The main thing to figure out here is how often this feature is used. Jan knew of at least one site, but it would be good to have actual telemetry. Indicating in the developer console it's deprecated would also be good. Having both of those puts us in a much better place to remove this.

Comment 1

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

Shawn, per my understanding, this benefits the design for Storage UX spec v1.5 (or v2.0) right? I am marking P2 for that reason as I guess we'd like to have the data ready before.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I will add this in open():
http://searchfox.org/mozilla-central/source/dom/indexedDB/IDBFactory.cpp#474

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1360567 - Add a telemetry probe for Indexeddb persistent type

Comment 4

[Jan Varga [:janv]]

It would also be interesting to see how many times "temporary" persistence type is used. Not just "persistent".

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1360567 - Add a telemetry probe for Indexeddb persistent type

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1360567 - Add telemetry probes for Indexeddb storage types

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8908101 [details] [diff] [review]
Bug 1360567 - Add telemetry probes for Indexeddb storage types

Add Francois. Since I saw his name on wiki. I'm not sure now who is the right person to ask for data review.
https://wiki.mozilla.org/Firefox/Data_Collection

Comment 8

[François Marier [:francois]]

Comment on attachment 8908101 [details] [diff] [review]
Bug 1360567 - Add telemetry probes for Indexeddb storage types

Review of attachment 8908101 [details] [diff] [review]:
-----------------------------------------------------------------

datareview+

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c147256cc10abdef30fdd14bb8eab62cd4dcb973

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c147256cc10a

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Persistent type count:
https://telemetry.mozilla.org/new-pipeline/evo.html#!aggregates=median&cumulative=0&end_date=2017-10-16&keys=!__none__!__none__!__none__&max_channel_version=beta%252F57&measure=SCALARS_IDB.TYPE.PERSISTENT_COUNT&min_channel_version=beta%252F57&processType=*&product=Firefox&sanitize=0&sort_keys=submissions&start_date=2017-09-25&trim=1&use_submission_date=0


Temporary type count:
https://telemetry.mozilla.org/new-pipeline/evo.html#!aggregates=median&cumulative=0&end_date=2017-10-16&keys=!__none__!__none__!__none__&max_channel_version=beta%252F57&measure=SCALARS_IDB.TYPE.TEMPORARY_COUNT&min_channel_version=beta%252F57&processType=*&product=Firefox&sanitize=0&sort_keys=submissions&start_date=2017-09-25&trim=1&use_submission_date=0