1360572 - The animation is inconsistently displayed after changing the tabs

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[roxleitan]

Attachment: graphics stability.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID:20170428030259

[Affected versions]:
Nightly 55.0a1

[Affected platforms]:
Windows 10, Ubuntu 16.04 x64

[Steps to reproduce]:
1.Launch Nightly 55.0a1 with a new profile
2.Navigate to https://bug1110686.bmoattachments.org/attachment.cgi?id=8535538
3.Open a new tab
4.Open a new window and navigate to about:memory
5.Click "Minimize memory usage" button
6.Go to the tab with the animation (opened at step 2)

[Expected result]:
The animation should be displayed without glitches

[Actual result]:
The animation is inconsistently displayed(please see the attachment)

Comment 1

[Timothy Nikkel (:tnikkel)]

Looks like an invalidation issue. Which is odd because I wrote code to handle this specific situation. I'll look into it.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: patch

I forgot to invalidate in one place.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dda520b4ed32
Invalidate the whole animated image when the composited frame becomes valid. r=aosmond

Comment 4

[Iris Hsiao [:ihsiao]]

backed this out for Assertion failure at RasterImage.cpp like https://treeherder.mozilla.org/logviewer.html#?job_id=96452645&repo=mozilla-inbound&lineNumber=1730

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1cfdc015e2f
Backed out changeset dda520b4ed32 for Assertion failure at RasterImage.cpp

Comment 6

[Timothy Nikkel (:tnikkel)]

Turns out that bug 1361642 was making this pass on try server. We get a decode call when we are currently decoded.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27e777d4ac38
Invalidate the whole animated image when the composited frame becomes valid. r=aosmond

Comment 8

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/27e777d4ac38

Comment 9

[roxleitan]

Verified as fixed using the latest Nightly 55.0a1 (2017-05-08) on Ubuntu 16.04 x64 and Windows 10 x64.