1360579 - Cannot scroll inside Google Flights options

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Go to the Google Flights page, choose "More" > "Connecting airport". I cannot scroll in the popup even though it briefly shows the scrollbar. It doesn't seem like a recent bug though, because I can't seem to scroll in Beta either.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I turned on some logging in the APZ code and it looks like the touch events are being preventDefault()'d in the popup, which is why scrolling doesn't happen. Using WebIDE I noted that there are touchstart/touchend listeners on the items inside that popup, but the code is minified/obfuscated so I didn't try to trace through it.

Comment 2

[Karl Dubost💡 :karlcow]

The script is difficult to unminify.

prettier and others are unable to treat it around here.

if (flights.succeeded) {
  flights.onScriptDownloaded([
    "
    // here long escaped JS code.
    "])


The code we need to understand the issue is in that giant mess. The developer tools are not extracting the array.
I tried a couple of techniques without success so far.

Another point. Chrome on Android is getting a totally different version.
I tested the version that Chrome is receiving and it is working as far as I know.

Maybe Thomas will have an idea for a suggested fix. So we could propose two opportunities to fix it to Google.

1. Fixing the JS
2. Sending us the tier1

Comment 3

[Rick Byers]

I verified I can reproduce this only when choosing "use classic google flights" and with Firefox sending it's default UA string.  If Firefox sends a Chrome UA string it seems to work fine, so I see no evidence that there's an interop issue at the root of this.  In the new Google flights UI this seems to work well in Firefox using either a Firefox or Chrome UA string.

So it seems to me like a site bug that's been fixed in the latest version, and so we should just close this bug.  Thoughts?

Comment 4

[Mike Taylor [:miketaylr]]

Attachment: old flights UI

Hey Rick, in Release, Beta and Nightly I still get the classic Flights UI with the busted scrolling. Do you know when thew new UI will be rolled out to all users? Thanks!

Comment 5

[Thomas Wisniewski [:twisniewski]]

I've confirmed that the Chrome version of the UI works with Firefox (with a UA spoof), but I'm still only getting the classic UI with the regular Firefox UA string.

It doesn't sound like further diagnosis is worth it, unless Rick thinks the classic UI will get an update before the new one rolls out.

Comment 6

[Rick Byers]

The classic UI is not going to be updated from what I can tell - it's dead and being replaced by the new UI across all browsers (though I don't have a clear timeline - sorry).

Comment 7

[Sergiu Logigan [:sergiu]]

The UI has changed for the Google Flights page.