Remove unused variable `maximized`

RESOLVED FIXED in Firefox 55

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: automatedtester, Assigned: soliver14, Mentored)

Tracking

({good-first-bug, pi-marionette-client})

Version 3
mozilla55
good-first-bug, pi-marionette-client
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [lang=py])

Attachments

(2 attachments)

(Reporter)

Updated

2 years ago
Summary: Remove unused variable → Remove unused variable `maximized`
Keywords: good-first-bug
Whiteboard: [good first bug][lang=py] → [lang=py]

Comment 1

2 years ago
I would like to claim this bug if it is still available.
Thanks.
(Reporter)

Comment 2

2 years ago
Jake, go for it! If there isnt a patch in a next couple weeks I will unassign.
Assignee: nobody → icanboard
(Assignee)

Comment 3

2 years ago
I am a member of Jake H's team in class.
This is my first time submitting a patch, thank you for you patience!
Cheers,
Stephen
Attachment #8864274 - Flags: review?(dburns)
(Reporter)

Comment 4

2 years ago
Comment on attachment 8864274 [details] [diff] [review]
of Jake H's team in class)Bug 1360586: Removed the unused varialble on line 81 of test_window_maximize.py

Review of attachment 8864274 [details] [diff] [review]:
-----------------------------------------------------------------

Stephen,

Thanks for the patch but this is not touching the right file. I assume you uploaded the wrong patch :)
Attachment #8864274 - Flags: review?(dburns)
(Assignee)

Comment 5

2 years ago
I attempted to follow the MDN "How to submit a patch" Guide. I am not entirely sure what I did wrong at this point. I can see the the changes in hg status and hg diff commands.
Are there any further tips you can give me so I can fix my attachment?

Thanks,
Stephen
(Assignee)

Updated

2 years ago
Flags: needinfo?(dburns)
(Reporter)

Comment 6

2 years ago
(In reply to Stephen Oliver from comment #5)
> I attempted to follow the MDN "How to submit a patch" Guide. I am not
> entirely sure what I did wrong at this point. I can see the the changes in
> hg status and hg diff commands.
> Are there any further tips you can give me so I can fix my attachment?
> 
> Thanks,
> Stephen

There are details in http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview-user.html which mean you can just push to a repo. Its kinda like how PRs work in Github.
Flags: needinfo?(dburns)

Comment 7

2 years ago
Hi , I would like to work on this bug . But this is my first project and I can not find the files to remove this bug. So if you can please provide some more information on this?

Comment 8

2 years ago
I am still working on it. We have the bug fix, but we (a few classmates) are working on the patch process. I think we understand it and should be submitting a patch during or after class tomorrow.
Comment hidden (mozreview-request)
(Assignee)

Comment 10

2 years ago
David, 

The patch should be submitted correctly now. Again, thank you for your patience with me on my first patch. Lastly, I am a member of Jake's team, just as a reminder.

Cheers!
-Stephen
(Reporter)

Comment 11

2 years ago
mozreview-review
Comment on attachment 8865571 [details]
Bug 1360586: Removed unused maximized variable

https://reviewboard.mozilla.org/r/137200/#review140264

::: commit-message-d7e40:1
(Diff revision 1)
> +bug1360586 - 'Removed unused mazimized variable as per request' r=automatedtester

Please can you fix the typo and remove `as per request` then this is ready to go!
Attachment #8865571 - Flags: review?(dburns) → review-
(Assignee)

Updated

2 years ago
Attachment #8865571 - Attachment description: bug1360586 - 'Removed unused mazimized variable as per request' → bug1360586 - 'Removed unused maximized variable'
(Assignee)

Comment 12

2 years ago
David,

Sorry about that, I fixed it up as you asked. How do the patch content look? Does everything seem to be in-order?

Cheers!
-Stephen
Flags: needinfo?(dburns)
(Reporter)

Comment 13

2 years ago
Stephen the code change looks good. I can't see your latest change, did you do |hg push review| with the updated commit message?
Flags: needinfo?(dburns)
(Assignee)

Comment 14

2 years ago
No, I just changed it via an edit in the bugzilla interface. When I tried to hg push review it complained that there was already an entry and aborted. Tips?
Flags: needinfo?(dburns)
Assignee: icanboard → soliver14
Status: NEW → ASSIGNED
(Reporter)

Comment 15

2 years ago
(In reply to Stephen Oliver from comment #14)
> No, I just changed it via an edit in the bugzilla interface. When I tried to
> hg push review it complained that there was already an entry and aborted.
> Tips?

So assuming your patch is the last commit do the following

hg histedit tip

where it says `pick` change that to `mess` for message and then exit the editor. Now change the message when it reopens. Save and exit.

Then you should be able to do |hg push review| again.
Flags: needinfo?(dburns)
Comment hidden (mozreview-request)
(Assignee)

Comment 17

2 years ago
David,

Again I find myself having to apologize. I royally screwed up my patch while trying to fix it so I had to remake it. My hope is this time everything is in order.

Thanks again for your seemingly endless patience with my n00b self.
cheers!
-Stephen
(Assignee)

Comment 18

2 years ago
One last addition/side note:
Turns out my team ended up using mq for generating out patches somehow. Not sure if that effects your previous advise at all.
(Reporter)

Comment 19

2 years ago
mozreview-review
Comment on attachment 8865571 [details]
Bug 1360586: Removed unused maximized variable

https://reviewboard.mozilla.org/r/137200/#review140726
Attachment #8865571 - Flags: review?(dburns) → review+
(Reporter)

Comment 20

2 years ago
(In reply to Stephen Oliver from comment #18)
> One last addition/side note:
> Turns out my team ended up using mq for generating out patches somehow. Not
> sure if that effects your previous advise at all.

It does. MQ is deprecated in mercurial, I suggest learning bookmarks which are analogous to git branches... kinda

Comment 21

2 years ago
Pushed by dburns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ee68d8541c8
Removed unused maximized variable r=automatedtester
(Assignee)

Comment 22

2 years ago
(In reply to David Burns :automatedtester from comment #20)
> (In reply to Stephen Oliver from comment #18)
> > One last addition/side note:
> > Turns out my team ended up using mq for generating out patches somehow. Not
> > sure if that effects your previous advise at all.
> 
> It does. MQ is deprecated in mercurial, I suggest learning bookmarks which
> are analogous to git branches... kinda

Will do! I will make it a point to look for some documentation tomorrow in class for whatever we end up working on next.

Comment 23

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1ee68d8541c8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.