1360615 - make it harder to do the wrong thing with CTLogOperatorInfo.id

Status: NEW

(Core :: Security: PSM, enhancement, P3)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Currently in our CT implementation, we have two arrays kCTLogList and kCTLogOperatorList. kCTLogList has numeric indices into kCTLogList. kCTLogList also has some numeric fields that look like indices, but they are not - they're CTLogOperatorIds. This is easy to forget and/or misunderstand, so we should make them an enum class or something.

I'm thinking:

enum class CTLogOperatorId : int16_t {
  Unknown = -1,
  Google = 0,
  DigiCert = 1,
(etc.)
  Venafi = 5,
  // there is no 6
  CNNIC = 7,
(etc.)
};

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information