1360639 - Space behind toolbar can be seen when entering/leaving the tabs tray

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Jan Henning [:JanH]]

When the web content slides out of/into view on opening/closing the tabs tray, a flash of red can be glimpsed.

Comment 1

[Randall Barker [:rbarker]]

Do you have steps to reproduce? I'm not seeing it on my device.

Comment 2

[Jan Henning [:JanH]]

Attachment: toolbar+tabs tray.mp4

Comment 3

[Randall Barker [:rbarker]]

The problem seems to be that when hiding the page for the tab view, the toolbar chrome and the content view are not animated together so the toolbar is not covering the content while being animated off screen. Since this is an android animation I don't see a good solution. To mitigate the problem, instead of drawing a red rectangle where the toolbar should be, just leave the clear color which on android is the pages background color.

Comment 4

[Randall Barker [:rbarker]]

Attachment: Bug 1360639 - Use the page background color when no dynamic toolbar snapshot is available

Review commit: https://reviewboard.mozilla.org/r/134864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134864/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8863021 [details]
Bug 1360639 - Use the page background color when no dynamic toolbar snapshot is available

https://reviewboard.mozilla.org/r/134864/#review137804

::: gfx/layers/composite/LayerManagerComposite.cpp:1150
(Diff revision 1)
> -    if (!effects.mPrimaryEffect) {
> -      // No toolbar texture so just draw a red square
> +    // If GetToolbarEffect return null, nothing is rendered so if not covered with the real toolbar chrome
> +    // the clear color will be visible which on Android is the pages background color.

I'm having a lot of trouble parsing this comment. Please stop the first sentence after "nothing is rendered" and make the rest of it a separate sentence (or sentences), rewording as needed.

Comment 6

[Jan Henning [:JanH]]

Interestingly enough now, having unplugged my phone from my computer in the meantime, I'm no longer really seeing this either. So presumably something there must have been eating CPU cycles and caused the toolbar diverge noticeably from the content beneath it.
Folks with really slow phone will probably still appreciate it even during normal usage, though.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43268ba5e94c
Use the page background color when no dynamic toolbar snapshot is available r=kats

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/43268ba5e94c

Comment 9

[Chris Peterson [:cpeterson]]

Moving toolbar bugs to the new GeckoView::Toolbar component.