bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Space behind toolbar can be seen when entering/leaving the tabs tray

RESOLVED FIXED in Firefox 55

Status

()

Firefox for Android
GeckoView
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: JanH, Assigned: rbarker)

Tracking

(Depends on: 1 bug)

55 Branch
Firefox 55
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 unaffected, firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
When the web content slides out of/into view on opening/closing the tabs tray, a flash of red can be glimpsed.
(Assignee)

Comment 1

a year ago
Do you have steps to reproduce? I'm not seeing it on my device.
Flags: needinfo?(jh+bugzilla)
(Reporter)

Comment 2

a year ago
Created attachment 8862960 [details]
toolbar+tabs tray.mp4
Flags: needinfo?(jh+bugzilla)
(Assignee)

Updated

a year ago
Assignee: nobody → rbarker
(Assignee)

Comment 3

a year ago
The problem seems to be that when hiding the page for the tab view, the toolbar chrome and the content view are not animated together so the toolbar is not covering the content while being animated off screen. Since this is an android animation I don't see a good solution. To mitigate the problem, instead of drawing a red rectangle where the toolbar should be, just leave the clear color which on android is the pages background color.
Comment hidden (mozreview-request)

Comment 5

a year ago
mozreview-review
Comment on attachment 8863021 [details]
Bug 1360639 - Use the page background color when no dynamic toolbar snapshot is available

https://reviewboard.mozilla.org/r/134864/#review137804

::: gfx/layers/composite/LayerManagerComposite.cpp:1150
(Diff revision 1)
> -    if (!effects.mPrimaryEffect) {
> -      // No toolbar texture so just draw a red square
> +    // If GetToolbarEffect return null, nothing is rendered so if not covered with the real toolbar chrome
> +    // the clear color will be visible which on Android is the pages background color.

I'm having a lot of trouble parsing this comment. Please stop the first sentence after "nothing is rendered" and make the rest of it a separate sentence (or sentences), rewording as needed.
Attachment #8863021 - Flags: review?(bugmail) → review+
(Reporter)

Comment 6

a year ago
Interestingly enough now, having unplugged my phone from my computer in the meantime, I'm no longer really seeing this either. So presumably something there must have been eating CPU cycles and caused the toolbar diverge noticeably from the content beneath it.
Folks with really slow phone will probably still appreciate it even during normal usage, though.

Comment 7

a year ago
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43268ba5e94c
Use the page background color when no dynamic toolbar snapshot is available r=kats
https://hg.mozilla.org/mozilla-central/rev/43268ba5e94c
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Depends on: 1360913
You need to log in before you can comment on or make changes to this bug.