1360793 - Permaorange leak in pdf.js browser-chrome tests when Gecko 55 merges to beta on 2017-06-12 due to bug 1348062

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect, P2)

Description

[Phil Ringnalda (:philor)]

In six weeks, when trunk merges to beta, the browser-chrome chunk that runs the pdf.js tests is going to have a permaleak like https://treeherder.mozilla.org/logviewer.html#?job_id=95033251&repo=try or https://treeherder.mozilla.org/logviewer.html#?job_id=95033462&repo=try on ASan, from bug 1348062.

Should be possible to reproduce locally by just changing /config/milestone.txt from 55a1 to 55, but if it's some more subtle part of the central-to-beta changes, the stack of patches in https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfaaa622d12692fedd9853e2e7ca051a19c7f285 should give you a full beta simulation on try.

Comment 1

[Phil Ringnalda (:philor)]

[Tracking Requested - why for this release]: merge bustage, closed tree, delayed b1, tearing of hair and rending of garments.

Comment 2

[Marcia Knous [:marcia]]

Tracking 55+ for this permaorange.

Comment 3

[Honza Bambas (:mayhemer)]

I *think* this comes from the core of how the throttling (interdicted in bug 1312754 ) is currently implemented.  I have plans to rewrite it a bit, specifically in relation to this bug - remove the parts that I suspect could cause this leak.  Bug 1362071.

Comment 4

[Honza Bambas (:mayhemer)]

If this needs to be fixed quickly, then we may want to back the offending patch (bug 1348062) out.  Otherwise see comment 3, bug 1362071 should be fixed in approx 2 weeks.

Comment 5

[Phil Ringnalda (:philor)]

Still have 5 weeks until the merge (and yeah, I'm carrying a backout of bug 1348062 around in my merge simulation stack, to keep it rebased and handy just in case).

Comment 6

[Honza Bambas (:mayhemer)]

(In reply to Phil Ringnalda (:philor) from comment #5)
> Still have 5 weeks until the merge (and yeah, I'm carrying a backout of bug
> 1348062 around in my merge simulation stack, to keep it rebased and handy
> just in case).

Thanks.  I will back bug 1348062 out should bug 1362071 be delayed.

Comment 7

[Mike Taylor [:miketaylr]]

Honza, with the soft code freeze coming up, do you think think 1362071 is in shape to land in time?

Comment 8

[Honza Bambas (:mayhemer)]

(In reply to Mike Taylor [:miketaylr] from comment #7)
> Honza, with the soft code freeze coming up, do you think think 1362071 is in
> shape to land in time?

The interesting bug is bug 1365306.  And yes, I'm about to r? and land it soon.

Comment 9

[Honza Bambas (:mayhemer)]

So, the probable fix has landed, can you please verify this bug is now fixed?

Comment 10

[Phil Ringnalda (:philor)]

Indeed, fixed by bug 1365306.