Closed Bug 1360878 Opened 8 years ago Closed 7 years ago

stylo: sequential cascade performance 3x worse than Gecko on Obama testcase

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bholley, Assigned: bholley)

References

(Blocks 1 open bug)

Details

I've been optimizing selector matching, but haven't started in too much on the cascade. The myspace testcase is pretty light on the cascade, whereas the obama testcase exercises it more. I did some profiling today and found a bunch of stuff we can do here.
I did my usual trick of hacking up a patch to make some stuff out of line: https://github.com/bholley/gecko/tree/out_of_line_cascade That gives us this profile here: https://perfht.ml/2oU1fRY , which shows us spending 35ms in the cascade. Gecko spends about 15-18ms in WalkRuleTree for the same testcase.
Depends on: 1360881
Depends on: 1360883
Depends on: 1361126
Depends on: 1361372
Depends on: 1361392
Depends on: 1360889
No longer depends on: 1361392
I'm no longer seeing this.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.