1360959 - Fix assert in ChromiumCDMChild::RecvDecrypt()

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

From bug 1358373 comment 20:

<quote>
Our Coverity analysis pointed out a small problem in this assertion:
http://searchfox.org/mozilla-central/rev/38fdbbcaa4be3a3f5b0d207dc5d53fb687c42d6a/dom/media/gmp/ChromiumCDMChild.cpp#606

Seems like it should be MOZ_ASSERT_IF(buffer, buffer->AsShmemBuffer());
</quote>

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1360959 - Only assert our buffer is shmem backed if we have a buffer in ChromiumCDMChild.

Review commit: https://reviewboard.mozilla.org/r/135082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135082/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8863285 [details]
Bug 1360959 - Only assert our buffer is shmem backed if we have a buffer in ChromiumCDMChild.

https://reviewboard.mozilla.org/r/135082/#review137956

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00dd395e56c4
Only assert our buffer is shmem backed if we have a buffer in ChromiumCDMChild. r=gerald

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/00dd395e56c4