Closed Bug 1360991 Opened 7 years ago Closed 7 years ago

stylo: text-align property glue doesn't handle -moz-prefixed values correctly

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1360991 - stylo: Adjust text expectations.
59 bytes, text/x-review-board-request
emilio
: review+
Details 
It takes values like -moz-center and stores them as NS_STYLE_TEXT_ALIGN_CENTER, when it needs to store them as NS_STYLE_TEXT_ALIGN_MOZ_CENTER.
Attachment #8863307 - Flags: review?(emilio+bugs)
Comment on attachment 8863307 [details]
style: Correctly handle Gecko prefixed text-align values in property glue.

https://reviewboard.mozilla.org/r/135104/#review138030

Nice catch!
Attachment #8863307 - Flags: review?(emilio+bugs) → review+
Comment on attachment 8863308 [details]
Bug 1360991 - stylo: Adjust text expectations.

https://reviewboard.mozilla.org/r/135106/#review138032
Attachment #8863308 - Flags: review?(emilio+bugs) → review+
Attachment #8863307 - Attachment is obsolete: true
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fc5c84e0a14
stylo: Adjust text expectations. r=emilio
https://hg.mozilla.org/mozilla-central/rev/2fc5c84e0a14
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: