1361032 - stylo: Remove redundant nsCSSValue getter/setter bindings

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

We can directly set/get `nsCSSValue` values and units without needing a binding(Like angle in bug 1360659). We don't have a reason to keep these unnecessary bindings. We should clean these and get/set in servo side directly.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

In general, we should make clear under what conditions we expect them to be called.

Right now all those functions imply that we're calling them either on values that don't hold any other memory from the parallel traversal (for calc()), or other values on main thread.

We should clean that up, presumably if we want to make them generic we could add bindings to nsCSSValue::Reset, and then just implement the getters and setters properly (and let Reset assert if we get it wrong).

The getters are just plain dumb I think.

Comment 2

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57