Closed
Bug 1361143
Opened 8 years ago
Closed 8 years ago
Missing expression statement restriction for "async function"
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
4.81 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Created test262 PR for tests at https://github.com/tc39/test262/pull/1017
|
|
Assignee | |
Comment 2•8 years ago
|
||
We only needed to move the syntax check from Parser::consequentOrAlternative() to Parser::statement(). And while I was there, I've also removed the check for "let" in strict or js1.7 mode, because strict-mode is also handled in Parser::checkLabelOrIdentifierReference() and if we care about js1.7 error messages, the js1.7 version check should also be moved Parser::checkLabelOrIdentifierReference().
Attachment #8863879 -
Flags: review?(shu)
|
||
Updated•8 years ago
|
Attachment #8863879 -
Flags: review?(shu) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d10c3cb00eede228507c291a21a356a883c205bc
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61ea278ec204
Enforce lookahead restriction for "async function" in expression statements. r=shu
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•