1361207 - Call nsIFrame::StyleDisplay less by changing callers of nsIFrame::IsThemed() wherever possible

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Comment 1

[Neerja Pancholi[:neerja]]

Created this bug to make the fix suggested for isThemed() by Jet in Bug 1351830 comment 2

Comment 2

[Neerja Pancholi[:neerja]]

Attachment: Bug 1361207 - Changed appropriate calls to nsIFrame::IsThemed() to use overload with nsStyleDisplay* as argument to avoid redundant calls to StyleDisplay()

Review commit: https://reviewboard.mozilla.org/r/135322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135322/

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8863563 [details]
Bug 1361207 - Changed appropriate calls to nsIFrame::IsThemed() to use overload with nsStyleDisplay* as argument to avoid redundant calls to StyleDisplay()

https://reviewboard.mozilla.org/r/135322/#review138286

Just one suggested commit-message tweak -- and with that, r=me, assuming this passes Try.  Thanks!

::: commit-message-57b37:1
(Diff revision 1)
> +Bug 1361207 - Changed appropriate calls to nsIFrame::IsThemed() to use overload with nsStyleDisplay* as argument to avoid unnecessary calls to StyleDisplay()

s/unnecessary/redundant/, to be more precise about what sorts of StyleDisplay() calls we're culling here.  (We still have to make one call, but we don't want to make any more than one.)

Thanks!

Comment 4

[Neerja Pancholi[:neerja]]

Comment on attachment 8863563 [details]
Bug 1361207 - Changed appropriate calls to nsIFrame::IsThemed() to use overload with nsStyleDisplay* as argument to avoid redundant calls to StyleDisplay()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135322/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0581aeb5e3fe
Changed appropriate calls to nsIFrame::IsThemed() to use overload with nsStyleDisplay* as argument to avoid redundant calls to StyleDisplay() r=dholbert

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0581aeb5e3fe