1361276 - Re-enable browser_oneOffHeader.js for OS X (gets intermittent from bug 1352364)

Status: RESOLVED FIXED

(Firefox :: Search, enhancement)

Description

[Johann Hofmann [:johannh]]

In bug 1352364 we change a lot of stuff but nothing particular to search AFAIK. browser_oneOffHeader still fails on try but we can't really reproduce it locally. It seems that this test is generally very brittle regarding timing. We'd like to avoid working on this in bug 1352364 since that one is big enough already and instead look at the test as a follow-up.

Comment 1

[Johann Hofmann [:johannh]]

Forgot to mention that this is only on OSX.

Comment 2

[Tooru Fujisawa [:arai]]

this is sometimes reproducible for me.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: (WIP) Put delay before triggering mouseover event in browser_oneOffHeader.js

(context: now I'm fixing bug 1416446 and others under bug 1414180, bug 1193394)

for me, mouseover event handler in synthesizeNativeMouseMove is not called and the test stops there, intermittently.
with this patch, the issue stops happening locally.
it delays the mouse event, and also move the cursor outside of the target element first, to make sure the cursor actually moves on the element.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Wait for mousemove instead of mouseover in browser/components/search/test/browser_oneOffHeader.js.

Looks like, it's waiting for wrong event.
the actual event used in search UI is mousemove, so it should also wait for mousemove, but it's waiting for mouseover, and sometimes it's not fired.
switching to mousemove fixes local intermittent.
I'll ask review after some more tests on automation.

Comment 5

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6a7812753ddf2ab101750ef644fef1c0bb730ba

Comment 6

[Tooru Fujisawa [:arai]]

Comment on attachment 8929309 [details] [diff] [review]
Wait for mousemove instead of mouseover in browser/components/search/test/browser_oneOffHeader.js.

Changed to wait for mousemove, and removed skip-if

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8929309 [details] [diff] [review]
Wait for mousemove instead of mouseover in browser/components/search/test/browser_oneOffHeader.js.

Review of attachment 8929309 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for taking care of this!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae9e1ead6772
Wait for mousemove instead of mouseover in browser/components/search/test/browser_oneOffHeader.js. r=johannh

Comment 9

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae9e1ead6772ccc0e7d201f67cc786fe76e53bdd
Bug 1361276 - Wait for mousemove instead of mouseover in browser/components/search/test/browser_oneOffHeader.js. r=johannh

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ae9e1ead6772