Closed Bug 1361322 Opened 7 years ago Closed 7 years ago

Don't try to open the favicons database on startup for existing profiles

Categories

(Toolkit :: Places, defect, P1)

Product:
Toolkit
Component:
Places
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Iteration:
55.6 - May 29
Project Flags:
Performance Impact medium
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch][reserve-photon-performance])

Attachments

(1 file)

Bug 1361322 - Don't try to open the favicons database on startup for existing profiles.
59 bytes, text/x-review-board-request
adw
: review+
Details 
things to do:
1. let's rely on ATTACH call succeeding rather than trying to detect corruption by opening/closing the db
2. in any case let's use asyncClose() to close the connection
3. in case of corruption, mark in a property which database was corrupt, places.sqlite or favicons.sqlite and then try to replace only that one
Blocks: 1361091
Blocks: photon-performance-triage
Whiteboard: [fxsearch][qf] → [fxsearch][qf][photon-performance]
Flags: qe-verify?
Priority: P1 → P2
Blocks: PlacesHiresFavicons
Whiteboard: [fxsearch][qf][photon-performance] → [fxsearch][qf:p1][photon-performance]
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [fxsearch][qf:p1][photon-performance] → [fxsearch][qf:p1][reserve-photon-performance]
hrm, Try is unhappy for some reason.
Attachment #8871249 - Flags: review?(adw)
New build to check if the issue is due to AsyncClose. My theory is that by the time we reach the ATTACH QUERY asyncClose is still running and it's not possible to ATTACH during a transaction (close is not a transaction, but I suspect part of it may work similarly). This may be compatible with the fact the previous patch was only failing on Linux, it's a different scheduler. Let's see. https://treeherder.mozilla.org/#/jobs?repo=try&revision=931128ae7453e2180aea1bc72f6b78dc2bb37077
Comment on attachment 8871249 [details]
Bug 1361322 - Don't try to open the favicons database on startup for existing profiles.

https://reviewboard.mozilla.org/r/142738/#review146624

LGTM
Attachment #8871249 - Flags: review?(adw) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/6f9a72ab2e18
Don't try to open the favicons database on startup for existing profiles. r=adw
Whiteboard: [fxsearch][qf:p1][reserve-photon-performance] → [fxsearch][qf:p2][reserve-photon-performance]
https://hg.mozilla.org/mozilla-central/rev/6f9a72ab2e18
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Iteration: --- → 55.6 - May 29
Flags: qe-verify? → qe-verify-
Performance Impact: --- → P2
Whiteboard: [fxsearch][qf:p2][reserve-photon-performance] → [fxsearch][reserve-photon-performance]
You need to log in before you can comment on or make changes to this bug.