Closed
Bug 1361357
Opened 7 years ago
Closed 7 years ago
Fix clip rect pushed in WebRenderDisplayItemLayer
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
The code in WebRenderDisplayItemLayer, when building a clip rect, uses 0,0 as the origin of the clip rect [1]. This seems wrong, and is inconsistent with how all the other layers behave - they use the visible bounds relative to the enclosing stacking context as their clip rect. I think WebRenderDisplayItemLayer should be doing the same. [1] http://searchfox.org/mozilla-central/rev/ae8c2e2354db652950fe0ec16983360c21857f2a/gfx/layers/wr/WebRenderDisplayItemLayer.cpp#42
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=30d62fac822dbf6ae6819ac52642cd9309ddaf83 includes this patch.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8863798 [details] Bug 1361357 - Try fixing clip on WRDILayer. https://reviewboard.mozilla.org/r/135552/#review138752
Attachment #8863798 -
Flags: review?(ethlin) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/ee8156686174 Try fixing clip on WRDILayer. r=ethlin
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ee8156686174
status-firefox55:
--- → fixed
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•