1361357 - Fix clip rect pushed in WebRenderDisplayItemLayer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

The code in WebRenderDisplayItemLayer, when building a clip rect, uses 0,0 as the origin of the clip rect [1]. This seems wrong, and is inconsistent with how all the other layers behave - they use the visible bounds relative to the enclosing stacking context as their clip rect. I think WebRenderDisplayItemLayer should be doing the same.

[1] http://searchfox.org/mozilla-central/rev/ae8c2e2354db652950fe0ec16983360c21857f2a/gfx/layers/wr/WebRenderDisplayItemLayer.cpp#42

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1361357 - Try fixing clip on WRDILayer.

This should fix some wrong-looking code that computes the clip for
WebRenderDisplayItemLayer instances. As this code is not exercised very
much it's hard to know if this change is actually correct.

Review commit: https://reviewboard.mozilla.org/r/135552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135552/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=30d62fac822dbf6ae6819ac52642cd9309ddaf83 includes this patch.

Comment 3

[Ethan Lin[:ethlin]]

Comment on attachment 8863798 [details]
Bug 1361357 - Try fixing clip on WRDILayer.

https://reviewboard.mozilla.org/r/135552/#review138752

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/ee8156686174
Try fixing clip on WRDILayer. r=ethlin

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/ee8156686174