Only render filter bar when relevant props have changed

RESOLVED FIXED in Firefox 55

Status

DevTools
Console
P1
normal
RESOLVED FIXED
a year ago
a month ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
Firefox 55
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [console-html])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Right now we are re-rendering the FilterBar and children on every change
Flags: qe-verify?
Priority: -- → P2
(Assignee)

Updated

a year ago
Flags: qe-verify? → qe-verify-
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: P2 → P1
Iteration: --- → 55.5 - May 15

Comment 3

a year ago
mozreview-review
Comment on attachment 8863821 [details]
Bug 1361429 - Grab only the filterBarVisible property to limit number of re-renders for FilterBar;

https://reviewboard.mozilla.org/r/135564/#review138746
Attachment #8863821 - Flags: review?(nchevobbe) → review+

Comment 4

a year ago
mozreview-review
Comment on attachment 8863822 [details]
Bug 1361429 - Convert FilterButton to functional component;

https://reviewboard.mozilla.org/r/135566/#review138748

Could you remove the `createFactory` call here http://searchfox.org/mozilla-central/source/devtools/client/webconsole/new-console-output/components/filter-bar.js#25 ? We shouldn't need it
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 7

a year ago
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)
> Comment on attachment 8863822 [details]
> Bug 1361429 - Convert FilterButton to functional component;
> 
> https://reviewboard.mozilla.org/r/135566/#review138748
> 
> Could you remove the `createFactory` call here
> http://searchfox.org/mozilla-central/source/devtools/client/webconsole/new-
> console-output/components/filter-bar.js#25 ? We shouldn't need it

Done, good catch

Comment 8

a year ago
mozreview-review
Comment on attachment 8863822 [details]
Bug 1361429 - Convert FilterButton to functional component;

https://reviewboard.mozilla.org/r/135566/#review138878
Attachment #8863822 - Flags: review?(nchevobbe) → review+

Comment 9

a year ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ce30397e7d2
Grab only the filterBarVisible property to limit number of re-renders for FilterBar;r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6a08f464248c
Convert FilterButton to functional component;r=nchevobbe

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2ce30397e7d2
https://hg.mozilla.org/mozilla-central/rev/6a08f464248c
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.