1361475 - AudioContext() constructor should not throw error when invoked with argument

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[Tomer Lahav]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

Steps to reproduce:

Run the following code:
new AudioContext({latencyHint: 'playback'});


Actual results:

Error is thrown:
TypeError: Argument 1 of AudioContext.constructor '[object Object]' is not a valid value for enumeration AudioChannel.


Expected results:

At the very least, this should not throw an error.
AudioContext() constructor should accept an options argument:
https://developer.mozilla.org/en-US/docs/Web/API/AudioContext/AudioContext

Comment 1

[Tooru Fujisawa [:arai]]

current implementation doesn't match to the spec.

https://dxr.mozilla.org/mozilla-central/rev/48c0fd9c9ec5d68061ea7b59358874ae8da72572/dom/webidl/AudioContext.webidl#14
> [Constructor,
>  Constructor(AudioChannel audioChannelType),
>  Pref="dom.webaudio.enabled"]
> interface AudioContext : BaseAudioContext {

https://dxr.mozilla.org/mozilla-central/rev/48c0fd9c9ec5d68061ea7b59358874ae8da72572/dom/webidl/AudioChannel.webidl#41-50
> enum AudioChannel {
>   "normal",
>   "content",
>   "notification",
>   "alarm",
>   "telephony",
>   "ringer",
>   "publicnotification",
>   "system"
> };

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1361475 - Remove proprietary constructor on AudioContext.

This was used only for B2G, was proprietary, and is causing issues, because
`AudioContext` can now have a parameter that is a property bag, per spec
(although we haven't implemented it at the moment).

Review commit: https://reviewboard.mozilla.org/r/136172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136172/

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8864498 [details]
Bug 1361475 - Remove proprietary constructor on AudioContext.

https://reviewboard.mozilla.org/r/136172/#review139160

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68543862570f
Remove proprietary constructor on AudioContext. r=baku

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68543862570f

Comment 6

[Eric Shepherd [:sheppy]]

Updated documents:

https://developer.mozilla.org/en-US/docs/Web/API/AudioContext/AudioContext
https://developer.mozilla.org/en-US/Firefox/Releases/55#Web_Audio_API