1361480 - Improve algorithm of 'size' and 'transferred' filters

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Sebastian Zartner [:sebo]]

The algorithm round(log10(size)) used for the 'size' and 'transferred' filters seems to be unexpected.

It should be improved to filter requests having a size approximately matching the entered number.

For example, the request size could be checked whether it falls into size - size / 10 and size + size / 10, where "size" is the entered size.

Sebastian

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1361480 - Improve logic for size related filters;

Review commit: https://reviewboard.mozilla.org/r/135728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135728/

Comment 2

[[e-mail]]

Comment on attachment 8864004 [details]
Bug 1361480 - Improve logic for size related filters;

https://reviewboard.mozilla.org/r/135728/#review139074

::: devtools/client/netmonitor/src/utils/filter-text-utils.js:216
(Diff revision 1)
>    }
>    return match;
>  }
>  
> +function isSizeMatch(value, size) {
> +  return value > (size - size / 10) && value < (size + size / 10);

That seems change the current behavior though, but looks reasonable. 

nit: we should use `>=` to include the exact number that user specified.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8864004 [details]
Bug 1361480 - Improve logic for size related filters;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135728/diff/1-2/

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8864004 [details]
Bug 1361480 - Improve logic for size related filters;

https://reviewboard.mozilla.org/r/135728/#review139074

> That seems change the current behavior though, but looks reasonable. 
> 
> nit: we should use `>=` to include the exact number that user specified.

Fixed

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/579a36c00c58
Improve logic for size related filters; r=gasolin

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/579a36c00c58