1361499 - coverity report: Non-static class member "mState" is not initialized in this constructor nor in any functions that it calls.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mats Palmgren (inactive)]

** CID 1405754:  Uninitialized members  (UNINIT_CTOR)
/layout/generic/nsIFrame.h: 615 in nsIFrame::nsIFrame(mozilla::FrameType)()


________________________________________________________________________________________________________
*** CID 1405754:  Uninitialized members  (UNINIT_CTOR)
/layout/generic/nsIFrame.h: 615 in nsIFrame::nsIFrame(mozilla::FrameType)()
609         , mParent(nullptr)
610         , mNextSibling(nullptr)
611         , mPrevSibling(nullptr)
612         , mType(aType)
613       {
614         mozilla::PodZero(&mOverflow);
>>>     CID 1405754:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mState" is not initialized in this constructor nor in any functions that it calls.
615       }
616     
617       nsPresContext* PresContext() const {
618         return StyleContext()->PresContext();
619       }
620

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

I think this is a false positive since the nsFrame ctor initialize it and
all frames we create derives from nsFrame:
http://searchfox.org/mozilla-central/rev/ae8c2e2354db652950fe0ec16983360c21857f2a/layout/generic/nsFrame.cpp#460

But we might as well initialize it properly, now that the pres shell arena
doesn't zero our memory anymore.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53042524877a
Initialize nsIFrame::mState in the ctor to avoid Coverity warnings.  r=jfkthame

Comment 3

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/53042524877a