Closed Bug 1361513 Opened 3 years ago Closed 3 years ago

coverity report: Non-static class member "mBaseline" is not initialized in this constructor nor in any functions that it calls.

Categories

(Core :: Layout: Block and Inline, defect)

53 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: mats, Assigned: emilio)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, regression, Whiteboard: [CID 1405755])

** CID 1405755:  Uninitialized members  (UNINIT_CTOR)
/layout/generic/nsInlineFrame.h: 146 in nsInlineFrame::nsInlineFrame(nsStyleContext *, mozilla::FrameType)()


________________________________________________________________________________________________________
*** CID 1405755:  Uninitialized members  (UNINIT_CTOR)
/layout/generic/nsInlineFrame.h: 146 in nsInlineFrame::nsInlineFrame(nsStyleContext *, mozilla::FrameType)()
140           mSetParentPointer = false;
141         }
142       };
143     
144       nsInlineFrame(nsStyleContext* aContext, mozilla::FrameType aType)
145         : nsContainerFrame(aContext, aType)
>>>     CID 1405755:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mBaseline" is not initialized in this constructor nor in any functions that it calls.
146       {}
147     
148       explicit nsInlineFrame(nsStyleContext* aContext)
149         : nsInlineFrame(aContext, mozilla::FrameType::Inline)
150       {}
151
Keywords: regression
We should init mBaseline in the ctor to NS_INTRINSIC_WIDTH_UNKNOWN
to catch any errors.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c74c35cc714
Initialize nsInlineFrame::mBaseline. r=mats
https://hg.mozilla.org/mozilla-central/rev/4c74c35cc714
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → emilio+bugs
Whiteboard: [CID 1405755]
You need to log in before you can comment on or make changes to this bug.