1361513 - coverity report: Non-static class member "mBaseline" is not initialized in this constructor nor in any functions that it calls.

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Mats Palmgren (inactive)]

** CID 1405755:  Uninitialized members  (UNINIT_CTOR)
/layout/generic/nsInlineFrame.h: 146 in nsInlineFrame::nsInlineFrame(nsStyleContext *, mozilla::FrameType)()


________________________________________________________________________________________________________
*** CID 1405755:  Uninitialized members  (UNINIT_CTOR)
/layout/generic/nsInlineFrame.h: 146 in nsInlineFrame::nsInlineFrame(nsStyleContext *, mozilla::FrameType)()
140           mSetParentPointer = false;
141         }
142       };
143     
144       nsInlineFrame(nsStyleContext* aContext, mozilla::FrameType aType)
145         : nsContainerFrame(aContext, aType)
>>>     CID 1405755:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mBaseline" is not initialized in this constructor nor in any functions that it calls.
146       {}
147     
148       explicit nsInlineFrame(nsStyleContext* aContext)
149         : nsInlineFrame(aContext, mozilla::FrameType::Inline)
150       {}
151

Comment 1

[Mats Palmgren (inactive)]

We should init mBaseline in the ctor to NS_INTRINSIC_WIDTH_UNKNOWN
to catch any errors.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c74c35cc714
Initialize nsInlineFrame::mBaseline. r=mats

Comment 3

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/4c74c35cc714