1361591 - Coverity report: nsMathMLmspaceFrame::​nsMathMLmspaceFrame(nsStyleContext *): A scalar field is not initialized by the constructor

Status: RESOLVED FIXED

(Core :: MathML, defect, P4)

Description

[Mats Palmgren (inactive)]

Coverity CID 750316 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.

In nsMathMLmspaceFrame::​nsMathMLmspaceFrame(nsStyleContext *): A scalar field is not initialized by the constructor 

38protected:
  2. uninit_member: Non-static class member mWidth is not initialized in this constructor nor in any functions that it calls.
  4. uninit_member: Non-static class member mHeight is not initialized in this constructor nor in any functions that it calls.
  CID 750316 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)6. uninit_member: Non-static class member mDepth is not initialized in this constructor nor in any functions that it calls.
39  explicit nsMathMLmspaceFrame(nsStyleContext* aContext) : nsMathMLContainerFrame(aContext) {}
40  virtual ~nsMathMLmspaceFrame();
41
42  virtual nsresult
43  MeasureForWidth(DrawTarget* aDrawTarget,
44                  ReflowOutput& aDesiredSize) override;
45
46private:
  1. member_decl: Class member declaration for mWidth.
47  nscoord mWidth;
  3. member_decl: Class member declaration for mHeight.
48  nscoord mHeight;
  5. member_decl: Class member declaration for mDepth.
49  nscoord mDepth;

Comment 1

[Mats Palmgren (inactive)]

We should init those three member fields to zero in the ctor:
http://searchfox.org/mozilla-central/rev/abe68d5dad139e376d5521ca1d4b7892e1e7f1ba/layout/mathml/nsMathMLmspaceFrame.h#39

Comment 2

[Frédéric Wang Nélar]

Attachment: Patch

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8865111 [details] [diff] [review]
Patch

>Bug 1361591 - Coverity report: nsMathMLmspaceFrame::ânsMathMLmspaceFrame(nsStyleContext *): A scalar field is not initialized by the constructor. r=karlt

Please describe in the commit message what the patch changes

(In reply to Mats Palmgren (:mats) from comment #1)
> We should init those three member fields to zero in the ctor:
> http://searchfox.org/mozilla-central/rev/
> abe68d5dad139e376d5521ca1d4b7892e1e7f1ba/layout/mathml/nsMathMLmspaceFrame.
> h#39

and why they should be set to zero in the constructor.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76845c4d9d5c
Coverity report: nsMathMLmspaceFrame:nsMathMLmspaceFrame(nsStyleContext *): A scalar field is not initialized by the constructor. r=karlt

Comment 5

[Jan de Mooij [:jandem]]

Drive-by comment, this landed with the wrong commit message (comment 3) and reviewer.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/76845c4d9d5c