Closed Bug 1361640 Opened 4 years ago Closed 4 years ago

"Restarting..." label in the app updater needs a throbber

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

Bug 1361640 - Add a throbber in front the "Restarting" label.
59 bytes, text/x-review-board-request
mikedeboer
: review+
Details 
Follow up to bug 1277747 (where "Restarting..." label was added) and was found when working on bug 1356507.
Tim, how can I test this? The patch LGTM code-wise - so when I can see it in action we're good here.
Flags: needinfo?(timdream)
See https://bugzilla.mozilla.org/show_bug.cgi?id=1277747#c23 :) It works on about:preferences#advanced too!
Flags: needinfo?(timdream)
Comment on attachment 8864871 [details]
Bug 1361640 - Add a throbber in front the "Restarting" label.

https://reviewboard.mozilla.org/r/136562/#review140636

Ship it!
Attachment #8864871 - Flags: review?(mdeboer) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cc27ea7fc377
Add a throbber in front the "Restarting" label. r=mikedeboer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cc27ea7fc377
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.