Closed Bug 1361645 Opened 2 years ago Closed 2 years ago

stylo: Add a styloVsGecko flag for the compareStyloToGecko test

Categories

(Core :: CSS Parsing and Computation, enhancement)

x86_64
Linux
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: shinglyu, Assigned: shinglyu)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

As dbaron suggested in Bug 1344132 comment 22, we can create a flag for styloVsGecko, so the flagss now become:

stylo => the linux64-stylo platform
styloVsGecko => linux64-stylo AND reftest.compareStyloToGecko=true

This will give us finer-grained control on the test expectation and better readability in reftest.lists
Attachment #8864028 - Flags: review?(dbaron)
Attachment #8864029 - Flags: review?(dbaron)
Comment on attachment 8864028 [details]
Bug 1361645 - Added the styloVsGecko reftest condition

https://reviewboard.mozilla.org/r/135740/#review140220

r=dbaron with the following comment

::: layout/tools/reftest/reftest.jsm:717
(Diff revision 2)
>      sandbox.webrtc = false;
>  #endif
>  
>  #ifdef MOZ_STYLO
>      sandbox.stylo = true;
> +    sandbox.styloVsGecko = gCompareStyloToGecko == true;

Drop the "== true".  (If there were a real concern that it might not be a boolean, use "!!" -- but I don't think there is.)
Attachment #8864028 - Flags: review?(dbaron) → review+
Comment on attachment 8864029 [details]
Bug 1361645 - Change reftest condition stylo to styloVsGecko

https://reviewboard.mozilla.org/r/135742/#review140222

r=dbaron, although independently, I'm a little concerned by the errors Xidorn is fixing in bug 1362255
Attachment #8864029 - Flags: review?(dbaron) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 6c4f2fa26f03 -d 5ae2cc64391c: rebasing 398221:6c4f2fa26f03 "Bug 1361645 - Added the styloVsGecko reftest condition r=dbaron"
rebasing 398222:0073754821e2 "Bug 1361645 - Change reftest condition stylo to styloVsGecko r=dbaron" (tip)
merging layout/reftests/backgrounds/reftest.list
merging layout/reftests/bugs/reftest.list
merging layout/reftests/css-placeholder/input/reftest.list
merging layout/reftests/forms/input/number/reftest.list
warning: conflicts while merging layout/reftests/bugs/reftest.list! (edit, then use 'hg resolve --mark')
warning: conflicts while merging layout/reftests/css-placeholder/input/reftest.list! (edit, then use 'hg resolve --mark')
warning: conflicts while merging layout/reftests/forms/input/number/reftest.list! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by slyu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b055c4e40da5
Added the styloVsGecko reftest condition r=dbaron
https://hg.mozilla.org/integration/autoland/rev/2ad8dd54b5f5
Change reftest condition stylo to styloVsGecko r=dbaron
https://hg.mozilla.org/mozilla-central/rev/b055c4e40da5
https://hg.mozilla.org/mozilla-central/rev/2ad8dd54b5f5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.